chrome/browser/extensions/api/bluetooth/bluetooth_api.cc - Issue 16295003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bluetooth/bluetooth_api.cc

Issue 16295003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/alarms/alarms_api_unittest.cc ('k') | chrome/browser/extensions/api/bluetooth/bluetooth_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bluetooth/bluetooth_api.cc

diff --git a/chrome/browser/extensions/api/bluetooth/bluetooth_api.cc b/chrome/browser/extensions/api/bluetooth/bluetooth_api.cc

index 6d4170a83495312c9c717204be6b52f385ab85d7..11c91f58579bdbccf25ee31c5d6644dfdeb55948 100644

--- a/chrome/browser/extensions/api/bluetooth/bluetooth_api.cc

+++ b/chrome/browser/extensions/api/bluetooth/bluetooth_api.cc

@@ -247,7 +247,7 @@ bool BluetoothGetProfilesFunction::DoWork(

bool BluetoothGetAdapterStateFunction::DoWork(

scoped_refptr<BluetoothAdapter> adapter) {

bluetooth::AdapterState state;

- PopulateAdapterState(*adapter, &state);

+ PopulateAdapterState(*adapter.get(), &state);

SetResult(state.ToValue().release());

SendResponse(true);

return true;

@@ -447,7 +447,7 @@ void BluetoothReadFunction::Work() {

return;

scoped_refptr<net::GrowableIOBuffer> buffer(new net::GrowableIOBuffer);

- success_ = socket_->Receive(buffer);

+ success_ = socket_->Receive(buffer.get());

if (success_)

SetResult(base::BinaryValue::CreateWithCopiedBuffer(buffer->StartOfBuffer(),

buffer->offset()));

@@ -501,8 +501,9 @@ void BluetoothWriteFunction::Work() {

scoped_refptr<net::WrappedIOBuffer> wrapped_io_buffer(

new net::WrappedIOBuffer(data_to_write_->GetBuffer()));

scoped_refptr<net::DrainableIOBuffer> drainable_io_buffer(

- new net::DrainableIOBuffer(wrapped_io_buffer, data_to_write_->GetSize()));

- success_ = socket_->Send(drainable_io_buffer);

+ new net::DrainableIOBuffer(wrapped_io_buffer.get(),

+ data_to_write_->GetSize()));

+ success_ = socket_->Send(drainable_io_buffer.get());

if (success_) {

if (drainable_io_buffer->BytesConsumed() > 0)

SetResult(