chrome/browser/browsing_data/cookies_tree_model.cc - Issue 16295003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/cookies_tree_model.cc

Issue 16295003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_remover_unittest.cc ('k') | chrome/browser/browsing_data/cookies_tree_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/cookies_tree_model.cc

diff --git a/chrome/browser/browsing_data/cookies_tree_model.cc b/chrome/browser/browsing_data/cookies_tree_model.cc

index 4c22203781d27f019b5a211162c7503e7869bbb0..a313b6946f5cb3fc71005c3d51b2f78a0f70e6b7 100644

--- a/chrome/browser/browsing_data/cookies_tree_model.cc

+++ b/chrome/browser/browsing_data/cookies_tree_model.cc

@@ -313,9 +313,9 @@ void CookieTreeAppCacheNode::DeleteStoredObjects() {

LocalDataContainer* container = GetLocalDataContainerForNode(this);

if (container) {

- DCHECK(container->appcache_helper_);

- container->appcache_helper_->DeleteAppCacheGroup(

- appcache_info_->manifest_url);

+ DCHECK(container->appcache_helper_.get());

+ container->appcache_helper_

+ ->DeleteAppCacheGroup(appcache_info_->manifest_url);

container->appcache_info_[origin_url_].erase(appcache_info_);

}

@@ -959,7 +959,7 @@ void CookiesTreeModel::UpdateSearchResults(const string16& filter) {

const ExtensionSet* CookiesTreeModel::ExtensionsProtectingNode(

const CookieTreeNode& cookie_node) {

- if (!special_storage_policy_)

+ if (!special_storage_policy_.get())

return NULL;

CookieTreeNode::DetailedInfo info = cookie_node.GetDetailedInfo();