chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc - Issue 16295003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc

Issue 16295003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_helper_unittest.cc ('k') | chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc

diff --git a/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc b/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc

index 269c6477ff9b2ae85caf14b7be66d50ec7d27dad..75e2a329006b7422281773ff232ca485ed387c38 100644

--- a/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc

+++ b/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc

@@ -113,10 +113,9 @@ IN_PROC_BROWSER_TEST_F(BrowsingDataLocalStorageHelperTest, CallbackCompletes) {

scoped_refptr<BrowsingDataLocalStorageHelper> local_storage_helper(

new BrowsingDataLocalStorageHelper(browser()->profile()));

CreateLocalStorageFilesForTest();

- StopTestOnCallback stop_test_on_callback(local_storage_helper);

- local_storage_helper->StartFetching(

- base::Bind(&StopTestOnCallback::Callback,

- base::Unretained(&stop_test_on_callback)));

+ StopTestOnCallback stop_test_on_callback(local_storage_helper.get());

+ local_storage_helper->StartFetching(base::Bind(

+ &StopTestOnCallback::Callback, base::Unretained(&stop_test_on_callback)));

// Blocks until StopTestOnCallback::Callback is notified.

content::RunMessageLoop();

}