Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Side by Side Diff: chrome/browser/extensions/convert_web_app_unittest.cc

Issue 16295003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/convert_web_app.h" 5 #include "chrome/browser/extensions/convert_web_app.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/file_util.h" 10 #include "base/file_util.h"
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 EXPECT_EQ(UTF16ToUTF8(web_app.title), extension->name()); 131 EXPECT_EQ(UTF16ToUTF8(web_app.title), extension->name());
132 EXPECT_EQ(UTF16ToUTF8(web_app.description), extension->description()); 132 EXPECT_EQ(UTF16ToUTF8(web_app.description), extension->description());
133 EXPECT_EQ(web_app.app_url, extension->GetFullLaunchURL()); 133 EXPECT_EQ(web_app.app_url, extension->GetFullLaunchURL());
134 EXPECT_EQ(2u, extension->GetActivePermissions()->apis().size()); 134 EXPECT_EQ(2u, extension->GetActivePermissions()->apis().size());
135 EXPECT_TRUE(extension->HasAPIPermission("geolocation")); 135 EXPECT_TRUE(extension->HasAPIPermission("geolocation"));
136 EXPECT_TRUE(extension->HasAPIPermission("notifications")); 136 EXPECT_TRUE(extension->HasAPIPermission("notifications"));
137 ASSERT_EQ(1u, extension->web_extent().patterns().size()); 137 ASSERT_EQ(1u, extension->web_extent().patterns().size());
138 EXPECT_EQ("http://aaronboodman.com/gearpad/*", 138 EXPECT_EQ("http://aaronboodman.com/gearpad/*",
139 extension->web_extent().patterns().begin()->GetAsString()); 139 extension->web_extent().patterns().begin()->GetAsString());
140 140
141 EXPECT_EQ(web_app.icons.size(), IconsInfo::GetIcons(extension).map().size()); 141 EXPECT_EQ(web_app.icons.size(),
142 IconsInfo::GetIcons(extension.get()).map().size());
142 for (size_t i = 0; i < web_app.icons.size(); ++i) { 143 for (size_t i = 0; i < web_app.icons.size(); ++i) {
143 EXPECT_EQ(base::StringPrintf("icons/%i.png", web_app.icons[i].width), 144 EXPECT_EQ(base::StringPrintf("icons/%i.png", web_app.icons[i].width),
144 IconsInfo::GetIcons(extension).Get( 145 IconsInfo::GetIcons(extension.get()).Get(
145 web_app.icons[i].width, ExtensionIconSet::MATCH_EXACTLY)); 146 web_app.icons[i].width, ExtensionIconSet::MATCH_EXACTLY));
146 ExtensionResource resource = IconsInfo::GetIconResource( 147 ExtensionResource resource =
147 extension, web_app.icons[i].width, ExtensionIconSet::MATCH_EXACTLY); 148 IconsInfo::GetIconResource(extension.get(),
149 web_app.icons[i].width,
150 ExtensionIconSet::MATCH_EXACTLY);
148 ASSERT_TRUE(!resource.empty()); 151 ASSERT_TRUE(!resource.empty());
149 EXPECT_TRUE(file_util::PathExists(resource.GetFilePath())); 152 EXPECT_TRUE(file_util::PathExists(resource.GetFilePath()));
150 } 153 }
151 } 154 }
152 155
153 TEST(ExtensionFromWebApp, Minimal) { 156 TEST(ExtensionFromWebApp, Minimal) {
154 base::ScopedTempDir extensions_dir; 157 base::ScopedTempDir extensions_dir;
155 ASSERT_TRUE(extensions_dir.CreateUniqueTempDir()); 158 ASSERT_TRUE(extensions_dir.CreateUniqueTempDir());
156 159
157 WebApplicationInfo web_app; 160 WebApplicationInfo web_app;
(...skipping 13 matching lines...) Expand all
171 EXPECT_TRUE(extension->is_hosted_app()); 174 EXPECT_TRUE(extension->is_hosted_app());
172 EXPECT_FALSE(extension->is_legacy_packaged_app()); 175 EXPECT_FALSE(extension->is_legacy_packaged_app());
173 176
174 EXPECT_EQ("lJqm1+jncOHClAuwif1QxNJKfeV9Fbl9IBZx7FkNwkA=", 177 EXPECT_EQ("lJqm1+jncOHClAuwif1QxNJKfeV9Fbl9IBZx7FkNwkA=",
175 extension->public_key()); 178 extension->public_key());
176 EXPECT_EQ("ncnbaadanljoanockmphfdkimpdedemj", extension->id()); 179 EXPECT_EQ("ncnbaadanljoanockmphfdkimpdedemj", extension->id());
177 EXPECT_EQ("1978.12.11.0", extension->version()->GetString()); 180 EXPECT_EQ("1978.12.11.0", extension->version()->GetString());
178 EXPECT_EQ(UTF16ToUTF8(web_app.title), extension->name()); 181 EXPECT_EQ(UTF16ToUTF8(web_app.title), extension->name());
179 EXPECT_EQ("", extension->description()); 182 EXPECT_EQ("", extension->description());
180 EXPECT_EQ(web_app.app_url, extension->GetFullLaunchURL()); 183 EXPECT_EQ(web_app.app_url, extension->GetFullLaunchURL());
181 EXPECT_EQ(0u, IconsInfo::GetIcons(extension).map().size()); 184 EXPECT_EQ(0u, IconsInfo::GetIcons(extension.get()).map().size());
182 EXPECT_EQ(0u, extension->GetActivePermissions()->apis().size()); 185 EXPECT_EQ(0u, extension->GetActivePermissions()->apis().size());
183 ASSERT_EQ(1u, extension->web_extent().patterns().size()); 186 ASSERT_EQ(1u, extension->web_extent().patterns().size());
184 EXPECT_EQ("*://aaronboodman.com/*", 187 EXPECT_EQ("*://aaronboodman.com/*",
185 extension->web_extent().patterns().begin()->GetAsString()); 188 extension->web_extent().patterns().begin()->GetAsString());
186 } 189 }
187 190
188 } // namespace extensions 191 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/convert_web_app.cc ('k') | chrome/browser/extensions/crx_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698