Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

chrome/browser/extensions/blacklist_unittest.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "base/run_loop.h"
 #include "chrome/browser/extensions/blacklist.h"
 #include "chrome/browser/extensions/extension_prefs.h"
 #include "chrome/browser/extensions/fake_safe_browsing_database_manager.h"
@@ skipping 39 matching lines @@
 TEST_F(BlacklistTest, SetFromUpdater) {
   scoped_refptr<const Extension> extension_a = prefs_.AddExtension("a");
   scoped_refptr<const Extension> extension_b = prefs_.AddExtension("b");
   scoped_refptr<const Extension> extension_c = prefs_.AddExtension("c");
   scoped_refptr<const Extension> extension_d = prefs_.AddExtension("d");
 
   // c, d, start blacklisted.
   prefs_.prefs()->SetExtensionBlacklisted(extension_c->id(), true);
   prefs_.prefs()->SetExtensionBlacklisted(extension_d->id(), true);
 
-  EXPECT_FALSE(IsBlacklisted(extension_a));
-  EXPECT_FALSE(IsBlacklisted(extension_b));
-  EXPECT_TRUE(IsBlacklisted(extension_c));
-  EXPECT_TRUE(IsBlacklisted(extension_d));
+  EXPECT_FALSE(IsBlacklisted(extension_a.get()));
+  EXPECT_FALSE(IsBlacklisted(extension_b.get()));
+  EXPECT_TRUE(IsBlacklisted(extension_c.get()));
+  EXPECT_TRUE(IsBlacklisted(extension_d.get()));
 
   // Mix up the blacklist.
   {
     std::vector<std::string> blacklist;
     blacklist.push_back(extension_b->id());
     blacklist.push_back(extension_c->id());
     blacklist_.SetFromUpdater(blacklist, "1");
   }
-  EXPECT_FALSE(IsBlacklisted(extension_a));
-  EXPECT_TRUE(IsBlacklisted(extension_b));
-  EXPECT_TRUE(IsBlacklisted(extension_c));
-  EXPECT_FALSE(IsBlacklisted(extension_d));
+  EXPECT_FALSE(IsBlacklisted(extension_a.get()));
+  EXPECT_TRUE(IsBlacklisted(extension_b.get()));
+  EXPECT_TRUE(IsBlacklisted(extension_c.get()));
+  EXPECT_FALSE(IsBlacklisted(extension_d.get()));
 
   // No-op, just in case.
   {
     std::vector<std::string> blacklist;
     blacklist.push_back(extension_b->id());
     blacklist.push_back(extension_c->id());
     blacklist_.SetFromUpdater(blacklist, "2");
   }
-  EXPECT_FALSE(IsBlacklisted(extension_a));
-  EXPECT_TRUE(IsBlacklisted(extension_b));
-  EXPECT_TRUE(IsBlacklisted(extension_c));
-  EXPECT_FALSE(IsBlacklisted(extension_d));
+  EXPECT_FALSE(IsBlacklisted(extension_a.get()));
+  EXPECT_TRUE(IsBlacklisted(extension_b.get()));
+  EXPECT_TRUE(IsBlacklisted(extension_c.get()));
+  EXPECT_FALSE(IsBlacklisted(extension_d.get()));
 
   // Strictly increase the blacklist.
   {
     std::vector<std::string> blacklist;
     blacklist.push_back(extension_a->id());
     blacklist.push_back(extension_b->id());
     blacklist.push_back(extension_c->id());
     blacklist.push_back(extension_d->id());
     blacklist_.SetFromUpdater(blacklist, "3");
   }
-  EXPECT_TRUE(IsBlacklisted(extension_a));
-  EXPECT_TRUE(IsBlacklisted(extension_b));
-  EXPECT_TRUE(IsBlacklisted(extension_c));
-  EXPECT_TRUE(IsBlacklisted(extension_d));
+  EXPECT_TRUE(IsBlacklisted(extension_a.get()));
+  EXPECT_TRUE(IsBlacklisted(extension_b.get()));
+  EXPECT_TRUE(IsBlacklisted(extension_c.get()));
+  EXPECT_TRUE(IsBlacklisted(extension_d.get()));
 
   // Strictly decrease the blacklist.
   {
     std::vector<std::string> blacklist;
     blacklist.push_back(extension_a->id());
     blacklist.push_back(extension_b->id());
     blacklist_.SetFromUpdater(blacklist, "4");
   }
-  EXPECT_TRUE(IsBlacklisted(extension_a));
-  EXPECT_TRUE(IsBlacklisted(extension_b));
-  EXPECT_FALSE(IsBlacklisted(extension_c));
-  EXPECT_FALSE(IsBlacklisted(extension_d));
+  EXPECT_TRUE(IsBlacklisted(extension_a.get()));
+  EXPECT_TRUE(IsBlacklisted(extension_b.get()));
+  EXPECT_FALSE(IsBlacklisted(extension_c.get()));
+  EXPECT_FALSE(IsBlacklisted(extension_d.get()));
 
   // Clear the blacklist.
   {
     std::vector<std::string> blacklist;
     blacklist_.SetFromUpdater(blacklist, "5");
   }
-  EXPECT_FALSE(IsBlacklisted(extension_a));
-  EXPECT_FALSE(IsBlacklisted(extension_b));
-  EXPECT_FALSE(IsBlacklisted(extension_c));
-  EXPECT_FALSE(IsBlacklisted(extension_d));
+  EXPECT_FALSE(IsBlacklisted(extension_a.get()));
+  EXPECT_FALSE(IsBlacklisted(extension_b.get()));
+  EXPECT_FALSE(IsBlacklisted(extension_c.get()));
+  EXPECT_FALSE(IsBlacklisted(extension_d.get()));
 }
 
 void Assign(std::set<std::string> *to, const std::set<std::string>& from) {
   *to = from;
 }
 
 TEST_F(BlacklistTest, OnlyIncludesRequestedIDs) {
   scoped_refptr<const Extension> extension_a = prefs_.AddExtension("a");
   scoped_refptr<const Extension> extension_b = prefs_.AddExtension("b");
   scoped_refptr<const Extension> extension_c = prefs_.AddExtension("c");
@@ skipping 30 matching lines @@
   prefs_.prefs()->SetExtensionBlacklisted(extension_a->id(), true);
   prefs_.prefs()->SetExtensionBlacklisted(extension_b->id(), true);
   {
     std::set<std::string> bc;
     bc.insert(extension_b->id());
     bc.insert(extension_c->id());
     safe_browsing_database_manager_->set_unsafe_ids(bc);
   }
 
   // The manager is still disabled at this point, so c won't be blacklisted.
-  EXPECT_TRUE(IsBlacklisted(extension_a));
-  EXPECT_TRUE(IsBlacklisted(extension_b));
-  EXPECT_FALSE(IsBlacklisted(extension_c));
+  EXPECT_TRUE(IsBlacklisted(extension_a.get()));
+  EXPECT_TRUE(IsBlacklisted(extension_b.get()));
+  EXPECT_FALSE(IsBlacklisted(extension_c.get()));
 
   // Now it should be.
   safe_browsing_database_manager_->set_enabled(true);
-  EXPECT_TRUE(IsBlacklisted(extension_a));
-  EXPECT_TRUE(IsBlacklisted(extension_b));
-  EXPECT_TRUE(IsBlacklisted(extension_c));
+  EXPECT_TRUE(IsBlacklisted(extension_a.get()));
+  EXPECT_TRUE(IsBlacklisted(extension_b.get()));
+  EXPECT_TRUE(IsBlacklisted(extension_c.get()));
 
   // Corner case: nothing in safebrowsing (but still enabled).
   safe_browsing_database_manager_->set_unsafe_ids(std::set<std::string>());
-  EXPECT_TRUE(IsBlacklisted(extension_a));
-  EXPECT_TRUE(IsBlacklisted(extension_b));
-  EXPECT_FALSE(IsBlacklisted(extension_c));
+  EXPECT_TRUE(IsBlacklisted(extension_a.get()));
+  EXPECT_TRUE(IsBlacklisted(extension_b.get()));
+  EXPECT_FALSE(IsBlacklisted(extension_c.get()));
 
   // Corner case: nothing in prefs.
   prefs_.prefs()->SetExtensionBlacklisted(extension_a->id(), false);
   prefs_.prefs()->SetExtensionBlacklisted(extension_b->id(), false);
   {
     std::set<std::string> bc;
     bc.insert(extension_b->id());
     bc.insert(extension_c->id());
     safe_browsing_database_manager_->set_unsafe_ids(bc);
   }
-  EXPECT_FALSE(IsBlacklisted(extension_a));
-  EXPECT_TRUE(IsBlacklisted(extension_b));
-  EXPECT_TRUE(IsBlacklisted(extension_c));
+  EXPECT_FALSE(IsBlacklisted(extension_a.get()));
+  EXPECT_TRUE(IsBlacklisted(extension_b.get()));
+  EXPECT_TRUE(IsBlacklisted(extension_c.get()));
 }
 
 }  // namespace extensions
 }  // namespace