content/browser/renderer_host/render_view_host_impl.cc - Issue 16294003: Update content/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 16294003: Update content/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | content/browser/renderer_host/render_view_host_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.cc

diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc

index e6b59ba8abb922903a1c9cbddc7e9545e1f238bc..73dd8d9ed6f1568d34b403dae349b59764cb2260 100644

--- a/content/browser/renderer_host/render_view_host_impl.cc

+++ b/content/browser/renderer_host/render_view_host_impl.cc

@@ -188,8 +188,8 @@ RenderViewHostImpl::RenderViewHostImpl(

static_cast<SessionStorageNamespaceImpl*>(session_storage)),

save_accessibility_tree_for_testing_(false),

render_view_termination_status_(base::TERMINATION_STATUS_STILL_RUNNING) {

- DCHECK(session_storage_namespace_);

- DCHECK(instance_);

+ DCHECK(session_storage_namespace_.get());

+ DCHECK(instance_.get());

CHECK(delegate_); // http://crbug.com/82827

if (main_frame_routing_id == MSG_ROUTING_NONE)

@@ -226,7 +226,7 @@ RenderViewHostDelegate* RenderViewHostImpl::GetDelegate() const {

}

SiteInstance* RenderViewHostImpl::GetSiteInstance() const {

- return instance_;

+ return instance_.get();

}

bool RenderViewHostImpl::CreateRenderView(