content/browser/geolocation/device_data_provider.h - Issue 16294003: Update content/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/geolocation/device_data_provider.h

Issue 16294003: Update content/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/fileapi/fileapi_message_filter.cc ('k') | content/browser/geolocation/geolocation_dispatcher_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/geolocation/device_data_provider.h

diff --git a/content/browser/geolocation/device_data_provider.h b/content/browser/geolocation/device_data_provider.h

index 431d7066c5cbcef84a9eefdbcd271fd967453b5f..c35e2562f089bbb52b6530fb321e469859b6d41e 100644

--- a/content/browser/geolocation/device_data_provider.h

+++ b/content/browser/geolocation/device_data_provider.h

@@ -253,11 +253,11 @@ class DeviceDataProvider : public base::NonThreadSafe {

DeviceDataProvider() {

DCHECK(factory_function_);

impl_ = (*factory_function_)();

- DCHECK(impl_);

+ DCHECK(impl_.get());

impl_->SetContainer(this);

}

virtual ~DeviceDataProvider() {

- DCHECK(impl_);

+ DCHECK(impl_.get());

impl_->SetContainer(NULL);

}

« no previous file with comments | « content/browser/fileapi/fileapi_message_filter.cc ('k') | content/browser/geolocation/geolocation_dispatcher_host.cc » ('j') | no next file with comments »