Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: content/browser/devtools/devtools_manager_unittest.cc

Issue 16294003: Update content/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_manager_unittest.cc
diff --git a/content/browser/devtools/devtools_manager_unittest.cc b/content/browser/devtools/devtools_manager_unittest.cc
index 6923a9379c76bad207772c00fac8b1c7979f8cc1..944850d2bb3f9d2ab31d361ffad544fcded78a85 100644
--- a/content/browser/devtools/devtools_manager_unittest.cc
+++ b/content/browser/devtools/devtools_manager_unittest.cc
@@ -136,7 +136,7 @@ TEST_F(DevToolsManagerTest, OpenAndManuallyCloseDevToolsClientHost) {
EXPECT_FALSE(agent->IsAttached());
TestDevToolsClientHost client_host;
- manager->RegisterDevToolsClientHostFor(agent, &client_host);
+ manager->RegisterDevToolsClientHostFor(agent.get(), &client_host);
// Test that the connection is established.
EXPECT_TRUE(agent->IsAttached());
EXPECT_EQ(agent, manager->GetDevToolsAgentHostFor(&client_host));
@@ -153,12 +153,12 @@ TEST_F(DevToolsManagerTest, ForwardMessageToClient) {
TestDevToolsClientHost client_host;
scoped_refptr<DevToolsAgentHost> agent_host(
DevToolsAgentHost::GetOrCreateFor(rvh()));
- manager->RegisterDevToolsClientHostFor(agent_host, &client_host);
+ manager->RegisterDevToolsClientHostFor(agent_host.get(), &client_host);
EXPECT_EQ(0, TestDevToolsClientHost::close_counter);
std::string m = "test message";
agent_host = DevToolsAgentHost::GetOrCreateFor(rvh());
- manager->DispatchOnInspectorFrontend(agent_host, m);
+ manager->DispatchOnInspectorFrontend(agent_host.get(), m);
EXPECT_TRUE(&m == client_host.last_sent_message);
client_host.Close(manager);
@@ -175,8 +175,8 @@ TEST_F(DevToolsManagerTest, NoUnresponsiveDialogInInspectedContents) {
TestDevToolsClientHost client_host;
scoped_refptr<DevToolsAgentHost> agent_host(
DevToolsAgentHost::GetOrCreateFor(inspected_rvh));
- DevToolsManager::GetInstance()->
- RegisterDevToolsClientHostFor(agent_host, &client_host);
+ DevToolsManager::GetInstance()->RegisterDevToolsClientHostFor(
+ agent_host.get(), &client_host);
// Start with a short timeout.
inspected_rvh->StartHangMonitorTimeout(TimeDelta::FromMilliseconds(10));
@@ -283,7 +283,7 @@ TEST_F(DevToolsManagerTest, TestExternalProxy) {
DevToolsManager* manager = DevToolsManager::GetInstance();
TestDevToolsClientHost client_host;
- manager->RegisterDevToolsClientHostFor(agent_host, &client_host);
+ manager->RegisterDevToolsClientHostFor(agent_host.get(), &client_host);
manager->DispatchOnInspectorBackend(&client_host, "message1");
manager->DispatchOnInspectorBackend(&client_host, "message2");
« no previous file with comments | « content/browser/devtools/devtools_manager_impl.cc ('k') | content/browser/devtools/devtools_netlog_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698