content/browser/device_orientation/message_filter.cc - Issue 16294003: Update content/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/device_orientation/message_filter.cc

Issue 16294003: Update content/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/device_orientation/device_orientation_browsertest.cc ('k') | content/browser/device_orientation/observer_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/device_orientation/message_filter.cc

diff --git a/content/browser/device_orientation/message_filter.cc b/content/browser/device_orientation/message_filter.cc

index f10ee08e0d8080ad7d894570910731c9e626ee22..2843f7d16e19ca607d84e1786da092f0c9870262 100644

--- a/content/browser/device_orientation/message_filter.cc

+++ b/content/browser/device_orientation/message_filter.cc

@@ -22,11 +22,11 @@ DeviceOrientationMessageFilter::~DeviceOrientationMessageFilter() {

void DeviceOrientationMessageFilter::OnStartUpdating(int render_view_id) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

- if (!provider_)

+ if (!provider_.get())

provider_ = Provider::GetInstance();

- observers_map_[render_view_id] = new ObserverDelegate(device_data_type_,

- provider_, render_view_id, this);

+ observers_map_[render_view_id] = new ObserverDelegate(

+ device_data_type_, provider_.get(), render_view_id, this);

}

void DeviceOrientationMessageFilter::OnStopUpdating(int render_view_id) {