Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 16290009: /etc/lsb-release doesn't exist on some non-Ubuntu variants of linux. (Closed)

Created:
7 years, 6 months ago by achuithb
Modified:
7 years, 6 months ago
Reviewers:
Tim Song, hartmanng
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

/etc/lsb-release doesn't exist on some non-Ubuntu variants of linux. BUG=244956 TEST=manual NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204008

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools/telemetry/telemetry/core/chrome/cros_browser_finder.py View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
achuithb
Tim, Glenn: Please take a look.
7 years, 6 months ago (2013-06-04 00:31:46 UTC) #1
Tim Song
lgtm LGTM.
7 years, 6 months ago (2013-06-04 17:21:19 UTC) #2
hartmanng
lgtm
7 years, 6 months ago (2013-06-04 17:25:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/16290009/1
7 years, 6 months ago (2013-06-04 18:33:59 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 18:34:30 UTC) #5
Message was sent while issue was closed.
Change committed as 204008

Powered by Google App Engine
This is Rietveld 408576698