Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 16290005: Move Pepper to using mailboxes (Closed)

Created:
7 years, 6 months ago by piman
Modified:
7 years, 6 months ago
Reviewers:
danakj, jamesr, jbauman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Move Pepper to using mailboxes This builds on top of https://codereview.chromium.org/15798014/ We can use the produced mailbox directly into the layer, removing the need for the context reparenting business. It also makes it work for the Übercompositor. This patch also removes the --disable-flash-fullscreen-3d flag, which has become unneeded - contexts fail to create if SwiftShader is on, there's no need to disable the output when reparenting (it doesn't work anyway unless we force lose the context). BUG=164095 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204655

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase, fix doc #

Patch Set 3 : build fix #

Total comments: 1

Patch Set 4 : nits #

Patch Set 5 : nits #

Patch Set 6 : nits #

Patch Set 7 : nits #

Patch Set 8 : nits #

Patch Set 9 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -168 lines) Patch
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_platform_context_3d_impl.h View 3 chunks +2 lines, -7 lines 0 comments Download
M content/renderer/pepper/pepper_platform_context_3d_impl.cc View 1 3 chunks +5 lines, -50 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 2 chunks +0 lines, -10 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.h View 1 chunk +0 lines, -4 lines 0 comments Download
content/renderer/render_widget_fullscreen_pepper.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M webkit/plugins/ppapi/fullscreen_container.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/plugin_delegate.h View 1 2 3 3 chunks +3 lines, -9 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 3 chunks +1 line, -11 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 7 chunks +14 lines, -35 lines 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_3d_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_3d_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
webkit/plugins/webkit_plugins.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
piman
7 years, 6 months ago (2013-06-01 01:35:09 UTC) #1
jbauman
lgtm
7 years, 6 months ago (2013-06-05 07:59:12 UTC) #2
danakj
https://codereview.chromium.org/16290005/diff/1/webkit/plugins/ppapi/plugin_delegate.h File webkit/plugins/ppapi/plugin_delegate.h (right): https://codereview.chromium.org/16290005/diff/1/webkit/plugins/ppapi/plugin_delegate.h#newcode225 webkit/plugins/ppapi/plugin_delegate.h:225: // mailbox identifier and sync_point, and return true. Otherwise ...
7 years, 6 months ago (2013-06-05 14:13:33 UTC) #3
piman
https://codereview.chromium.org/16290005/diff/1/webkit/plugins/ppapi/plugin_delegate.h File webkit/plugins/ppapi/plugin_delegate.h (right): https://codereview.chromium.org/16290005/diff/1/webkit/plugins/ppapi/plugin_delegate.h#newcode225 webkit/plugins/ppapi/plugin_delegate.h:225: // mailbox identifier and sync_point, and return true. Otherwise ...
7 years, 6 months ago (2013-06-05 17:57:54 UTC) #4
danakj
Ooh LGTM from my time machine.
7 years, 6 months ago (2013-06-05 18:04:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/16290005/6001
7 years, 6 months ago (2013-06-05 18:08:17 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-05 19:34:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/16290005/28001
7 years, 6 months ago (2013-06-06 02:50:20 UTC) #8
piman
+jamesr for webkit/plugins/webkit_plugins.gypi OWNERs
7 years, 6 months ago (2013-06-06 02:51:04 UTC) #9
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=7175
7 years, 6 months ago (2013-06-06 04:11:28 UTC) #10
jamesr
lgtm https://chromiumcodereview.appspot.com/16290005/diff/28001/webkit/plugins/ppapi/plugin_delegate.h File webkit/plugins/ppapi/plugin_delegate.h (right): https://chromiumcodereview.appspot.com/16290005/diff/28001/webkit/plugins/ppapi/plugin_delegate.h#newcode19 webkit/plugins/ppapi/plugin_delegate.h:19: #include "cc/resources/texture_mailbox.h" is this include used?
7 years, 6 months ago (2013-06-06 05:25:08 UTC) #11
piman
On 2013/06/06 05:25:08, jamesr wrote: > lgtm > > https://chromiumcodereview.appspot.com/16290005/diff/28001/webkit/plugins/ppapi/plugin_delegate.h > File webkit/plugins/ppapi/plugin_delegate.h (right): > ...
7 years, 6 months ago (2013-06-06 19:41:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/16290005/57001
7 years, 6 months ago (2013-06-06 19:51:20 UTC) #13
commit-bot: I haz the power
7 years, 6 months ago (2013-06-06 23:37:01 UTC) #14
Message was sent while issue was closed.
Change committed as 204655

Powered by Google App Engine
This is Rietveld 408576698