Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 16285005: Don't track whether a resize ack is pending during layout tests (Closed)

Created:
7 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Don't track whether a resize ack is pending during layout tests Unlike normal operation, in layout tests the renderer can request a synchronous change of its size. The renderer and the browser therefore often run out of sync. However, it's important that the renderer always acks a resize request from the browser. Previously, I tried to track the size the browser expects the renderer to have in the renderer, however, this turns out to not work when the compositor is in hidpi mode. Instead of trying to fix this up somehow, just ignore whether or not the browser is expecting resize acks during layout tests BUG=244369 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204014

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Patch Set 4 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 3 chunks +8 lines, -1 line 0 comments Download
M content/renderer/render_widget.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 4 chunks +9 lines, -6 lines 0 comments Download
M content/test/layout_browsertest.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M content/test/layouttest_support.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
John, can you please review this?
7 years, 6 months ago (2013-06-03 12:57:57 UTC) #1
jam
lgtm
7 years, 6 months ago (2013-06-03 15:56:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/16285005/7001
7 years, 6 months ago (2013-06-03 19:18:29 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=46379
7 years, 6 months ago (2013-06-03 20:49:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/16285005/18001
7 years, 6 months ago (2013-06-04 11:17:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/16285005/20005
7 years, 6 months ago (2013-06-04 12:39:04 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 19:20:09 UTC) #7
Message was sent while issue was closed.
Change committed as 204014

Powered by Google App Engine
This is Rietveld 408576698