Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 16284009: Don't deref XMLHttpRequest synchronously below stop() (Closed)

Created:
7 years, 6 months ago by abarth-chromium
Modified:
7 years, 6 months ago
Reviewers:
eseidel
CC:
blink-reviews, eae+blinkwatch, japhet-do-not-use
Visibility:
Public.

Description

Don't deref XMLHttpRequest synchronously below stop() Prior to this CL, we could release our last reference to XMLHttpRequest synchronously below XMLHttpRequest::stop. That can cause us to call ScriptExecutionContext::willDestroyActiveDOMObject synchronously below stop(), which will hit a CRASH() because we're trying to mutate the set of ActiveDOMObject while we're iterating the set. This CL simply makes the deref() happen asynchronously, preventing us from mutating the set during iteration. BUG=247395 R=eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152266

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M Source/core/xml/XMLHttpRequest.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
abarth-chromium
7 years, 6 months ago (2013-06-11 23:27:12 UTC) #1
eseidel
lgtm I believe you this is an OK fix. I wish we had a test ...
7 years, 6 months ago (2013-06-12 00:11:39 UTC) #2
abarth-chromium
On 2013/06/12 00:11:39, eseidel wrote: > I wish we had a test or understood how ...
7 years, 6 months ago (2013-06-12 00:45:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/16284009/1
7 years, 6 months ago (2013-06-12 00:45:31 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-12 06:39:01 UTC) #5
Message was sent while issue was closed.
Change committed as 152266

Powered by Google App Engine
This is Rietveld 408576698