Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 16283002: Move Extension::UpdatesFromGallery to ManifestURL. (Closed)

Created:
7 years, 6 months ago by Yoyo Zhou
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Move Extension::UpdatesFromGallery to ManifestURL. BUG=162530 TBR=jhawkins@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203886

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M chrome/browser/extensions/crx_installer.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_install_ui.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_downloader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/extension.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/common/extensions/manifest_url_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/manifest_url_handler.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Yoyo Zhou
7 years, 6 months ago (2013-05-31 23:21:54 UTC) #1
Matt Perry
lgtm
7 years, 6 months ago (2013-05-31 23:26:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/16283002/1
7 years, 6 months ago (2013-05-31 23:28:05 UTC) #3
Yoyo Zhou
TBR=jhawkins for refactoring to webui
7 years, 6 months ago (2013-05-31 23:32:04 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 6 months ago (2013-06-03 00:09:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/16283002/1
7 years, 6 months ago (2013-06-03 00:54:25 UTC) #6
commit-bot: I haz the power
Failed to apply patch for chrome/browser/extensions/external_install_ui.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 6 months ago (2013-06-03 00:54:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/16283002/17001
7 years, 6 months ago (2013-06-03 21:06:12 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 07:06:40 UTC) #9
Message was sent while issue was closed.
Change committed as 203886

Powered by Google App Engine
This is Rietveld 408576698