Introduce PPB_UDPSocket_Dev.

ppapi/proxy/udp_socket_shared.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef PPAPI_PROXY_UDP_SOCKET_SHARED_H_
+#define PPAPI_PROXY_UDP_SOCKET_SHARED_H_
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
+#include "base/memory/ref_counted.h"
+#include "ppapi/c/private/ppb_net_address_private.h"
+#include "ppapi/c/private/ppb_udp_socket_private.h"
+#include "ppapi/proxy/plugin_resource.h"
+#include "ppapi/proxy/ppapi_proxy_export.h"
+#include "ppapi/shared_impl/tracked_callback.h"
+
+namespace ppapi {
+namespace proxy {
+
+class ResourceMessageReplyParams;
+
+class PPAPI_PROXY_EXPORT UDPSocketShared: public PluginResource {

[bbudge, 2013/06/10 12:59:56]

Naming: 'Shared' is slightly confusing, since we also use it to mean 'used on
both sides of proxy'. Maybe a better name would be UDPSocketResourceBase.

[yzshen1, 2013/06/10 22:10:35]

Thanks! It sounds much better to be UDPSocketResourceBase.

On 2013/06/10 12:59:56, bbudge1 wrote:

+ public:
+  UDPSocketShared(Connection connection, PP_Instance instance);

[bbudge, 2013/06/10 12:59:56]

Is it ever OK to instantiate this class? If not, maybe make ctor protected.

[yzshen1, 2013/06/10 22:10:35]

Done.

On 2013/06/10 12:59:56, bbudge1 wrote:

+  virtual ~UDPSocketShared();
+
+  // The maximum number of bytes that each PpapiHostMsg_PPBUDPSocket_RecvFrom
+  // message is allowed to request.
+  static const int32_t kMaxReadSize;
+  // The maximum number of bytes that each PpapiHostMsg_PPBUDPSocket_SendTo
+  // message is allowed to carry.
+  static const int32_t kMaxWriteSize;
+
+  int32_t SetSocketFeatureImpl(PP_UDPSocketFeature_Private name,
+                               const PP_Var& value);
+  int32_t BindImpl(const PP_NetAddress_Private* addr,
+                   scoped_refptr<TrackedCallback> callback);
+  PP_Bool GetBoundAddressImpl(PP_NetAddress_Private* addr);
+  // |addr| could be NULL to indicate that an output value is not needed.
+  int32_t RecvFromImpl(char* buffer,
+                       int32_t num_bytes,
+                       PP_Resource* addr,
+                       scoped_refptr<TrackedCallback> callback);
+  PP_Bool GetRecvFromAddressImpl(PP_NetAddress_Private* addr);
+  int32_t SendToImpl(const char* buffer,
+                     int32_t num_bytes,
+                     const PP_NetAddress_Private* addr,
+                     scoped_refptr<TrackedCallback> callback);
+  void CloseImpl();
+
+ private:
+  void PostAbortIfNecessary(scoped_refptr<TrackedCallback>* callback);
+
+  // IPC message handlers.
+  void OnPluginMsgBindReply(const ResourceMessageReplyParams& params,
+                            const PP_NetAddress_Private& bound_addr);
+  void OnPluginMsgRecvFromReply(PP_Resource* output_addr,
+                                const ResourceMessageReplyParams& params,
+                                const std::string& data,
+                                const PP_NetAddress_Private& addr);
+  void OnPluginMsgSendToReply(const ResourceMessageReplyParams& params,
+                              int32_t bytes_written);
+
+  bool bound_;
+  bool closed_;
+
+  scoped_refptr<TrackedCallback> bind_callback_;
+  scoped_refptr<TrackedCallback> recvfrom_callback_;
+  scoped_refptr<TrackedCallback> sendto_callback_;
+
+  char* read_buffer_;
+  int32_t bytes_to_read_;
+
+  PP_NetAddress_Private recvfrom_addr_;
+  PP_NetAddress_Private bound_addr_;
+
+  DISALLOW_COPY_AND_ASSIGN(UDPSocketShared);
+};
+
+}  // namespace proxy
+}  // namespace ppapi
+
+#endif  // PPAPI_PROXY_UDP_SOCKET_SHARED_H_