Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 16282003: Translate: make alpha language support enabled by default (Closed)

Created:
7 years, 6 months ago by Takashi Toyoshima
Modified:
7 years, 6 months ago
Reviewers:
MAD
CC:
chromium-reviews
Visibility:
Public.

Description

Translate: make alpha language support enabled by default After r203462 translate UI/UX meets criterions to enable it by default. Now, let's enable alpha language support by default. BUG=242178 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203981

Patch Set 1 #

Patch Set 2 : comment update #

Patch Set 3 : (rebase) #

Patch Set 4 : fix browser_tests #

Patch Set 5 : rebase due to conflict in CQ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -47 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/translate/translate_language_list.h View 1 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/translate/translate_language_list.cc View 1 2 3 5 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 1 2 3 2 chunks +9 lines, -7 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Takashi Toyoshima
Hi mad, Now I'll enable alpha language support by default. Can I take a look ...
7 years, 6 months ago (2013-06-03 04:37:21 UTC) #1
MAD
lgtm
7 years, 6 months ago (2013-06-03 15:10:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/16282003/2001
7 years, 6 months ago (2013-06-03 15:11:29 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=46270
7 years, 6 months ago (2013-06-03 17:25:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/16282003/22001
7 years, 6 months ago (2013-06-04 03:30:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/16282003/22001
7 years, 6 months ago (2013-06-04 08:41:24 UTC) #6
commit-bot: I haz the power
Failed to apply patch for chrome/common/chrome_switches.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 6 months ago (2013-06-04 08:41:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/16282003/34001
7 years, 6 months ago (2013-06-04 09:00:45 UTC) #8
Takashi Toyoshima
CQ looks confused. I use NOTRY=true.
7 years, 6 months ago (2013-06-04 15:50:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/16282003/34001
7 years, 6 months ago (2013-06-04 15:51:02 UTC) #10
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 16:49:02 UTC) #11
Message was sent while issue was closed.
Change committed as 203981

Powered by Google App Engine
This is Rietveld 408576698