Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 16280005: RegExp macro assembler clean up. (Closed)

Created:
7 years, 6 months ago by Rodolph Perfetta
Modified:
7 years, 6 months ago
Reviewers:
erikcorry, ulan, Yang
CC:
v8-dev
Visibility:
Public.

Description

RegExp macro assembler clean up. Removes never called methods and fix a bug on ARM. BUG=none TEST=none Committed: https://code.google.com/p/v8/source/detail?r=14967

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -378 lines) Patch
M src/arm/regexp-macro-assembler-arm.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/arm/regexp-macro-assembler-arm.cc View 2 chunks +1 line, -49 lines 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.cc View 1 chunk +0 lines, -80 lines 0 comments Download
M src/mips/regexp-macro-assembler-mips.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/mips/regexp-macro-assembler-mips.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M src/regexp-macro-assembler.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/regexp-macro-assembler-irregexp.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/regexp-macro-assembler-irregexp.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/regexp-macro-assembler-tracer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/regexp-macro-assembler-tracer.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/x64/regexp-macro-assembler-x64.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 1 chunk +0 lines, -95 lines 0 comments Download
M test/cctest/test-regexp.cc View 3 chunks +43 lines, -32 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Rodolph Perfetta
7 years, 6 months ago (2013-06-05 19:14:15 UTC) #1
Yang
7 years, 6 months ago (2013-06-06 08:32:03 UTC) #2
On 2013/06/05 19:14:15, Rodolph Perfetta wrote:

LGTM!

Powered by Google App Engine
This is Rietveld 408576698