Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 16278006: In DownloadOperation use locally modified file info if dirty Drive cache exists. (Closed)

Created:
7 years, 6 months ago by kinaba
Modified:
7 years, 6 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik+watch_chromium.org, oshima+watch_chromium.org, tfarina, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

In DownloadOperation use locally modified file info if dirty Drive cache exists. BUG=245693 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203940

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -10 lines) Patch
M chrome/browser/chromeos/drive/file_system/download_operation.cc View 1 4 chunks +32 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation_unittest.cc View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kinaba
ptal. The patch duplicates some code with drive::FileSystem which is bad, but I don't think ...
7 years, 6 months ago (2013-06-03 09:45:32 UTC) #1
hashimoto
lgtm https://codereview.chromium.org/16278006/diff/2018/chrome/browser/chromeos/drive/file_system/download_operation.cc File chrome/browser/chromeos/drive/file_system/download_operation.cc (right): https://codereview.chromium.org/16278006/diff/2018/chrome/browser/chromeos/drive/file_system/download_operation.cc#newcode77 chrome/browser/chromeos/drive/file_system/download_operation.cc:77: // be stored in |entry|. nit: Could you ...
7 years, 6 months ago (2013-06-03 10:33:27 UTC) #2
kinaba
https://codereview.chromium.org/16278006/diff/2018/chrome/browser/chromeos/drive/file_system/download_operation.cc File chrome/browser/chromeos/drive/file_system/download_operation.cc (right): https://codereview.chromium.org/16278006/diff/2018/chrome/browser/chromeos/drive/file_system/download_operation.cc#newcode77 chrome/browser/chromeos/drive/file_system/download_operation.cc:77: // be stored in |entry|. On 2013/06/03 10:33:27, hashimoto ...
7 years, 6 months ago (2013-06-04 03:30:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/16278006/7001
7 years, 6 months ago (2013-06-04 03:30:53 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 12:46:50 UTC) #5
Message was sent while issue was closed.
Change committed as 203940

Powered by Google App Engine
This is Rietveld 408576698