Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 16278003: Made possible to lock and unlock with several logged in users. (Closed)

Created:
7 years, 6 months ago by dzhioev (left Google)
Modified:
7 years, 6 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, nkostylev+watch_chromium.org, kkania, robertshield, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Made possible to lock and unlock with several logged in users. Every signed in user can lock and unlock screen. User entering password becomes active after unlock. Changed only backend part. UI changes and tests will follow. BUG=239228 TEST=manually TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203712

Patch Set 1 #

Total comments: 9

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -70 lines) Patch
M chrome/browser/automation/testing_automation_provider_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screen_locker.h View 6 chunks +16 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker.cc View 1 8 chunks +50 lines, -41 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker_delegate.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_screen_locker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_screen_locker.cc View 1 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 4 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dzhioev (left Google)
7 years, 6 months ago (2013-06-03 08:42:49 UTC) #1
Nikita (slow)
lgtm with nits https://codereview.chromium.org/16278003/diff/1/chrome/browser/chromeos/login/screen_locker.cc File chrome/browser/chromeos/login/screen_locker.cc (right): https://codereview.chromium.org/16278003/diff/1/chrome/browser/chromeos/login/screen_locker.cc#newcode279 chrome/browser/chromeos/login/screen_locker.cc:279: LOG(ERROR) << "Invalid user trying to ...
7 years, 6 months ago (2013-06-03 09:04:15 UTC) #2
dzhioev (left Google)
https://codereview.chromium.org/16278003/diff/1/chrome/browser/chromeos/login/screen_locker.cc File chrome/browser/chromeos/login/screen_locker.cc (right): https://codereview.chromium.org/16278003/diff/1/chrome/browser/chromeos/login/screen_locker.cc#newcode279 chrome/browser/chromeos/login/screen_locker.cc:279: LOG(ERROR) << "Invalid user trying to unlock."; On 2013/06/03 ...
7 years, 6 months ago (2013-06-03 09:39:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/16278003/1002
7 years, 6 months ago (2013-06-03 09:40:27 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=6354
7 years, 6 months ago (2013-06-03 09:47:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/16278003/1002
7 years, 6 months ago (2013-06-03 10:31:27 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-03 14:11:50 UTC) #7
Message was sent while issue was closed.
Change committed as 203712

Powered by Google App Engine
This is Rietveld 408576698