Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: content/browser/renderer_host/render_process_host_browsertest.cc

Issue 16267002: Re-fix http://crbug.com/87176, and add a test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add comment Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_browsertest.cc
diff --git a/content/browser/renderer_host/render_process_host_browsertest.cc b/content/browser/renderer_host/render_process_host_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..9ee8036e04492da8db60512bda903abc85ae0561
--- /dev/null
+++ b/content/browser/renderer_host/render_process_host_browsertest.cc
@@ -0,0 +1,50 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/common/child_process_messages.h"
+#include "content/public/browser/notification_types.h"
+#include "content/public/browser/render_process_host.h"
+#include "content/public/browser/render_view_host.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/test/test_notification_tracker.h"
+#include "content/shell/shell.h"
+#include "content/test/content_browser_test.h"
+#include "content/test/content_browser_test_utils.h"
+#include "net/test/embedded_test_server/embedded_test_server.h"
+
+namespace content {
+namespace {
+
+class RenderProcessHostTest : public ContentBrowserTest {};
+
+// Sometimes the renderer process's ShutdownRequest (corresponding to the
+// ViewMsg_WasSwappedOut from a previous navigation) doesn't arrive until after
+// the browser process decides to re-use the renderer for a new purpose. This
+// test makes sure the browser doesn't let the renderer die in that case. See
+// http://crbug.com/87176.
+IN_PROC_BROWSER_TEST_F(RenderProcessHostTest,
+ ShutdownRequestFromActiveTabIgnored) {
+ ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
+
+ GURL test_url = embedded_test_server()->GetURL("/simple_page.html");
+ NavigateToURL(shell(), test_url);
+ RenderProcessHost* rph =
+ shell()->web_contents()->GetRenderViewHost()->GetProcess();
+
+ TestNotificationTracker termination_watcher;
+ termination_watcher.ListenFor(NOTIFICATION_RENDERER_PROCESS_CLOSED,
+ Source<RenderProcessHost>(rph));
+ ChildProcessHostMsg_ShutdownRequest msg;
+ rph->OnMessageReceived(msg);
+
+ // If the RPH sends a mistaken ChildProcessMsg_Shutdown, the renderer process
+ // will take some time to die. Wait for a second tab to load in order to give
+ // that time to happen.
+ NavigateToURL(CreateBrowser(), test_url);
+
+ EXPECT_EQ(0U, termination_watcher.size());
+}
+
+} // namespace
+} // namespace content
« no previous file with comments | « chrome/browser/extensions/extension_host.cc ('k') | content/browser/renderer_host/render_process_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698