Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 16261002: Preload HSTS for paypal.com. (Closed)

Created:
7 years, 6 months ago by palmer
Modified:
7 years, 6 months ago
Reviewers:
agl, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Preload HSTS for paypal.com. Not just www.paypal.com. BUG=245148 TEST=Navigating to http://paypal.com causes no HTTP traffic, only HTTPS traffic. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204373

Patch Set 1 #

Patch Set 2 : Fix unit tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M net/http/transport_security_state_static.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/transport_security_state_static.json View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/transport_security_state_unittest.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
palmer
We might not actually submit this. Pending OK from Brad Hill (PayPal). But I wanted ...
7 years, 6 months ago (2013-05-31 18:24:00 UTC) #1
Ryan Sleevi
lgtm
7 years, 6 months ago (2013-05-31 18:24:53 UTC) #2
palmer
This has the OK from Brad.
7 years, 6 months ago (2013-06-04 17:51:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/16261002/1
7 years, 6 months ago (2013-06-04 17:54:05 UTC) #4
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=57793
7 years, 6 months ago (2013-06-04 18:26:57 UTC) #5
agl
Looks like you need to update the unittests?
7 years, 6 months ago (2013-06-04 18:28:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/16261002/16001
7 years, 6 months ago (2013-06-05 17:33:25 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-06-06 01:17:33 UTC) #8
Message was sent while issue was closed.
Change committed as 204373

Powered by Google App Engine
This is Rietveld 408576698