Issue 16258010: Make my_activity.py robust to log parsing problems

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16258010: Make my_activity.py robust to log parsing problems (Closed)

Created:
7 years, 6 months ago by enne (OOO)

Modified:
7 years, 6 months ago

Reviewers:
szager1

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, cjhopman

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Make my_activity.py robust to log parsing problems If (hypothetically) you pointed your WebKit repo environment variable to Blink and not WebKit, then the change_re will not find anything in the log and the script will explode on changes[0] because changes=[]. Fix this by being robust to not being able to parse anything out of the log in process_git_commits. R=szager@chromium.org BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=205290

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	my_activity.py	View		2 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/16258010/1

7 years, 6 months ago (2013-06-10 20:18:21 UTC) #3

Message was sent while issue was closed.

Change committed as 205290

Expand Messages | Collapse Messages