Add tool to generate PropertyConverter implementations for proto messages.

Add tool to generate PropertyConverter implementations for proto messages.

R=dnj@chromium.org, estaab@chromium.org, martiniss@chromium.org, vadimsh@chromium.org
BUG=

Committed: https://github.com/luci/gae/commit/fc6a3943c17800288641bf4391132d2f08a43f33

[dnj, 2016-01-23 06:15:36]

lgtm w/ nit + comment

https://chromiumcodereview.appspot.com/1625773002/diff/1/tools/proto-gae/READ...
File tools/proto-gae/README.md (right):

https://chromiumcodereview.appspot.com/1625773002/diff/1/tools/proto-gae/READ...
tools/proto-gae/README.md:6: `protoc`-generated message types. This allows you
to embed proto.Message
nit: Back-ticks around proto.Message

https://chromiumcodereview.appspot.com/1625773002/diff/1/tools/proto-gae/prot...
File tools/proto-gae/proto_gae.go (right):

https://chromiumcodereview.appspot.com/1625773002/diff/1/tools/proto-gae/prot...
tools/proto-gae/proto_gae.go:121: if err :=
a.parseArgs(flag.NewFlagSet(os.Args[0], flag.ContinueOnError), os.Args); err !=
nil {
nit: Why ContinueOnError instead of ExitOnError?

https://chromiumcodereview.appspot.com/1625773002/diff/1/tools/proto-gae/prot...
tools/proto-gae/proto_gae.go:129: defer ofile.Close()
I suppose in theory if Close fails this could fail to completely generate. Also
maybe use bufio since you're doing a bunch of successive writes?

[iannucci, 2016-01-23 10:00:31]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2016-01-23 10:00:32]

The patchset sent to the CQ was uploaded after l-g-t-m from dnj@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1625773002/#ps20001
(title: "Fix nit, use bufio")

[commit-bot: I haz the power, 2016-01-23 10:00:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1625773002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1625773002/20001

[iannucci, 2016-01-23 10:01:07]

https://chromiumcodereview.appspot.com/1625773002/diff/1/tools/proto-gae/READ...
File tools/proto-gae/README.md (right):

https://chromiumcodereview.appspot.com/1625773002/diff/1/tools/proto-gae/READ...
tools/proto-gae/README.md:6: `protoc`-generated message types. This allows you
to embed proto.Message
On 2016/01/23 06:15:36, dnj wrote:
> nit: Back-ticks around proto.Message

Done.

https://chromiumcodereview.appspot.com/1625773002/diff/1/tools/proto-gae/prot...
File tools/proto-gae/proto_gae.go (right):

https://chromiumcodereview.appspot.com/1625773002/diff/1/tools/proto-gae/prot...
tools/proto-gae/proto_gae.go:121: if err :=
a.parseArgs(flag.NewFlagSet(os.Args[0], flag.ContinueOnError), os.Args); err !=
nil {
On 2016/01/23 06:15:36, dnj wrote:
> nit: Why ContinueOnError instead of ExitOnError?

So that I could theoretically test this, except I don't.

https://chromiumcodereview.appspot.com/1625773002/diff/1/tools/proto-gae/prot...
tools/proto-gae/proto_gae.go:129: defer ofile.Close()
On 2016/01/23 06:15:36, dnj wrote:
> I suppose in theory if Close fails this could fail to completely generate.
Also
> maybe use bufio since you're doing a bunch of successive writes?

done, though it's completely overkill.

[commit-bot: I haz the power, 2016-01-23 10:03:13]

Description was changed from

==========
Add tool to generate PropertyConverter implementations for proto messages.

R=dnj@chromium.org, estaab@chromium.org, martiniss@chromium.org,
vadimsh@chromium.org
BUG=
==========

to

==========
Add tool to generate PropertyConverter implementations for proto messages.

R=dnj@chromium.org, estaab@chromium.org, martiniss@chromium.org,
vadimsh@chromium.org
BUG=

Committed:
https://github.com/luci/gae/commit/fc6a3943c17800288641bf4391132d2f08a43f33
==========

[commit-bot: I haz the power, 2016-01-23 10:03:14]

Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/fc6a3943c17800288641bf4391132d2f08a43f33