Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16256028: Add @DisabledTest decorator (Closed)

Created:
7 years, 6 months ago by nduca
Modified:
7 years, 6 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

Add @DisabledTest decorator Tests decorated with @DisabledTest aren't run unless explicitly by passing ./run_tests --also-run-disabled-tests BUG=243558 R=tonyg NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203817

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Patch Set 3 : @DisabledTest #

Patch Set 4 : rebase on dtus directory move #

Total comments: 1

Patch Set 5 : fix rebasing issue #

Patch Set 6 : curses #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -20 lines) Patch
M tools/telemetry/telemetry/core/chrome/cros_interface_unittest.py View 1 2 3 8 chunks +9 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/core/chrome/form_based_credentials_backend_unittest_base.py View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/unittest/__init__.py View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/unittest/run_tests.py View 1 2 3 5 chunks +13 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
nduca
7 years, 6 months ago (2013-06-03 23:26:12 UTC) #1
dtu
https://codereview.chromium.org/16256028/diff/1/tools/telemetry/telemetry/test/run_tests.py File tools/telemetry/telemetry/test/run_tests.py (right): https://codereview.chromium.org/16256028/diff/1/tools/telemetry/telemetry/test/run_tests.py#newcode100 tools/telemetry/telemetry/test/run_tests.py:100: help='Only run tests decorated with @ManuallyRunTest.') This option runs ...
7 years, 6 months ago (2013-06-03 23:40:07 UTC) #2
tonyg
https://codereview.chromium.org/16256028/diff/1/tools/telemetry/telemetry/test/__init__.py File tools/telemetry/telemetry/test/__init__.py (right): https://codereview.chromium.org/16256028/diff/1/tools/telemetry/telemetry/test/__init__.py#newcode10 tools/telemetry/telemetry/test/__init__.py:10: def ManuallyRunTest(func): Chromium's GTest calls this DISABLED. Should we ...
7 years, 6 months ago (2013-06-03 23:53:37 UTC) #3
nduca
How about @DisabledTest, and -d//--also-run-disabled-tests to clarify the comments from both?
7 years, 6 months ago (2013-06-04 00:40:00 UTC) #4
tonyg
On 2013/06/04 00:40:00, nduca wrote: > How about @DisabledTest, and -d//--also-run-disabled-tests to clarify the > ...
7 years, 6 months ago (2013-06-04 02:19:24 UTC) #5
tonyg
https://codereview.chromium.org/16256028/diff/10001/tools/telemetry/telemetry/unittest/__init__.py File tools/telemetry/telemetry/unittest/__init__.py (right): https://codereview.chromium.org/16256028/diff/10001/tools/telemetry/telemetry/unittest/__init__.py#newcode4 tools/telemetry/telemetry/unittest/__init__.py:4: def RequiresBrowserOfType(*types): These are also defined in core/__init__.py. Can't ...
7 years, 6 months ago (2013-06-04 02:21:14 UTC) #6
nduca
Looks like that was a rebasing issue. My bad, fixed.
7 years, 6 months ago (2013-06-04 02:28:29 UTC) #7
tonyg
lgtm
7 years, 6 months ago (2013-06-04 02:31:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/16256028/20001
7 years, 6 months ago (2013-06-04 02:36:40 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 02:39:43 UTC) #10
Message was sent while issue was closed. 
Change committed as 203817

Powered by Google App Engine
This is Rietveld 408576698