content/browser/indexed_db/leveldb/leveldb_transaction.h - Issue 16256014: IndexedDB: Convert decoding functions to pass StringPieces vs. pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/leveldb/leveldb_transaction.h

Issue 16256014: IndexedDB: Convert decoding functions to pass StringPieces vs. pointers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Correct bogus iterator dereference in unit test Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/indexed_db/leveldb/leveldb_slice.h ('k') | content/browser/indexed_db/leveldb/leveldb_transaction.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/leveldb/leveldb_transaction.h

diff --git a/content/browser/indexed_db/leveldb/leveldb_transaction.h b/content/browser/indexed_db/leveldb/leveldb_transaction.h

index 6d0d29bbc28ce07443b68ba955c595e117ec8971..ad93833aad6d926b861dfde93d253ea2383bdb6a 100644

--- a/content/browser/indexed_db/leveldb/leveldb_transaction.h

+++ b/content/browser/indexed_db/leveldb/leveldb_transaction.h

@@ -27,7 +27,7 @@ class CONTENT_EXPORT LevelDBTransaction

void Put(const LevelDBSlice& key, const std::vector<char>& value);

void Remove(const LevelDBSlice& key);

- bool Get(const LevelDBSlice& key, std::vector<char>& value, bool& found);

+ bool Get(const LevelDBSlice& key, std::string* value, bool& found);

bool Commit();

void Rollback();

« no previous file with comments | « content/browser/indexed_db/leveldb/leveldb_slice.h ('k') | content/browser/indexed_db/leveldb/leveldb_transaction.cc » ('j') | no next file with comments »