content/browser/indexed_db/indexed_db_backing_store_unittest.cc - Issue 16256014: IndexedDB: Convert decoding functions to pass StringPieces vs. pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_backing_store_unittest.cc

Issue 16256014: IndexedDB: Convert decoding functions to pass StringPieces vs. pointers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Correct bogus iterator dereference in unit test Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/indexed_db/indexed_db_backing_store.cc ('k') | content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/indexed_db_backing_store_unittest.cc

diff --git a/content/browser/indexed_db/indexed_db_backing_store_unittest.cc b/content/browser/indexed_db/indexed_db_backing_store_unittest.cc

index a24148e74bb1fb0195dd754129bf5bb81405f750..235e4865a485e16902cc55d429acfbf66bf0e691 100644

--- a/content/browser/indexed_db/indexed_db_backing_store_unittest.cc

+++ b/content/browser/indexed_db/indexed_db_backing_store_unittest.cc

@@ -90,7 +90,8 @@ TEST_F(IndexedDBBackingStoreTest, HighIds) {

const int64 invalid_high_index_id = 1ULL << 37;

const IndexedDBKey& index_key = m_key2;

- std::vector<char> index_key_raw = EncodeIDBKey(index_key);

+ std::vector<char> index_key_raw;

+ EncodeIDBKey(index_key, &index_key_raw);

{

IndexedDBBackingStore::Transaction transaction1(backing_store_.get());

transaction1.begin();