Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 16256011: Don't crash if device creation fails in bench. (Closed)

Created:
7 years, 6 months ago by bsalomon
Modified:
7 years, 6 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Don't crash if device creation fails in bench. Committed: http://code.google.com/p/skia/source/detail?r=9417

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -123 lines) Patch
M bench/benchmain.cpp View 1 2 chunks +133 lines, -123 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
The differ is doing a bad job. I just added the code to set declare ...
7 years, 6 months ago (2013-06-03 14:50:04 UTC) #1
robertphillips
lgtm
7 years, 6 months ago (2013-06-03 14:52:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/16256011/3
7 years, 6 months ago (2013-06-03 17:03:10 UTC) #3
commit-bot: I haz the power
Retried try job too often on Build-Mac10.7-Clang-x86-Release-Trybot for step(s) BuildSkiaBaseLibs http://108.170.217.252:10117/buildstatus?builder=Build-Mac10.7-Clang-x86-Release-Trybot&number=77
7 years, 6 months ago (2013-06-03 17:28:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/16256011/3
7 years, 6 months ago (2013-06-03 19:30:56 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-03 19:31:09 UTC) #6
Message was sent while issue was closed.
Change committed as 9417

Powered by Google App Engine
This is Rietveld 408576698