Issue 16254003: WIP - Code Review

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16254003: WIP (Closed)

Created:
7 years, 6 months ago by bartfab (slow)

Modified:
7 years, 3 months ago

Reviewers:

CC:
chromium-reviews, nkostylev+watch_chromium.org, sail+watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

WIP BUG=

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+520 lines, -78 lines)			Patch
M	chrome/browser/browser_process.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_process_impl.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_process_impl.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/existing_user_controller.h	View	3 chunks	+12 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/existing_user_controller.cc	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/storage/managed_value_store_cache.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/storage/settings_apitest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/io_thread.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/async_policy_provider_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/browser_policy_connector.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/cloud_policy_browsertest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/cloud_policy_manager.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/cloud_policy_manager_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/config_dir_policy_loader.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/config_dir_policy_loader_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/configuration_policy_pref_store.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/configuration_policy_pref_store_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/configuration_policy_provider.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/configuration_policy_provider.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/configuration_policy_provider_test.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/device_cloud_policy_manager_chromeos_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/device_local_account_policy_provider.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/device_local_account_policy_service_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/managed_mode_policy_provider.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/managed_mode_policy_provider_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/mock_configuration_policy_provider.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/network_configuration_updater.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/policy_bundle.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
A	chrome/browser/policy/policy_change_watcher.h	View	1 chunk	+106 lines, -0 lines	0 comments	Download
A	chrome/browser/policy/policy_change_watcher.cc	View	1 chunk	+190 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/policy_loader_mac.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/policy_loader_mac_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/policy_loader_win.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/policy_loader_win_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/browser/policy/policy_namespace.h	View	1 chunk	+47 lines, -0 lines	0 comments	Download
A	chrome/browser/policy/policy_namespace.cc	View	1 chunk	+41 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/policy_service.h	View	2 chunks	+4 lines, -33 lines	0 comments	Download
M	chrome/browser/policy/policy_service.cc	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	chrome/browser/policy/policy_service_impl.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/policy/policy_service_impl.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/policy/policy_service_stub.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/policy/policy_service_stub.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/policy/policy_statistics_collector.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/policy_statistics_collector_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/proxy_policy_provider_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/test_utils.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/user_cloud_policy_manager_chromeos.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/user_cloud_policy_manager_chromeos_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/user_cloud_policy_manager_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/user_policy_signin_service.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/prefs/browser_prefs.cc	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/profiles/profile_impl.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/policy_ui.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	4 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/common/pref_names.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/test/base/testing_browser_process.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/test/base/testing_browser_process.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download