Reload Lo-Fi images inline instead of reloading the whole page

content/public/browser/web_contents.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
 
 #include <stdint.h>
 
 #include <set>
@@ skipping 428 matching lines @@
   // Replaces the currently selected word or a word around the cursor.
   virtual void Replace(const base::string16& word) = 0;
 
   // Replaces the misspelling in the current selection.
   virtual void ReplaceMisspelling(const base::string16& word) = 0;
 
   // Let the renderer know that the menu has been closed.
   virtual void NotifyContextMenuClosed(
       const CustomContextMenuContext& context) = 0;
 
+  // Reloads all the Lo-Fi images in this WebContents. Ignores the cache and
+  // reloads from the network.

[Charlie Reis, 2016/01/29 23:01:12]

Is this supposed to disable LoFi state as well?  Is there any LoFi state in the
browser, or does that only exist in RenderFrameImpl?

[megjablon, 2016/01/29 23:22:23]

Yes it disables LoFi. If the user requests that LoFi images are loaded, they
should not get more LoFi images after this request. Does
ReloadAndDisableLoFiImages work better? The only LoFi state is RenderFrameImpl.

[Charlie Reis, 2016/01/29 23:52:00]

Ok.  I just wasn't clear whether there was additional state.

No need to change the method name, but please do mention that this disables LoFi
in the comment.

+  virtual void ReloadLoFiImages() = 0;

[Charlie Reis, 2016/01/29 23:01:12]

This doesn't really belong in the Editing commands section.

There's no LoFi mentions in this class yet and it's kind of similar to
NavigationController::ReloadDisableLoFi, so that would be one option.

I suppose it's not really navigation related, though, so maybe it's ok to put it
below ReloadFocusedFrame in the Commands section above.  (Please reorder in the
impl files as well.)

[megjablon, 2016/01/29 23:22:23]

Done.

+
   // Executes custom context menu action that was provided from Blink.
   virtual void ExecuteCustomContextMenuCommand(
       int action, const CustomContextMenuContext& context) = 0;
 
   // Views and focus -----------------------------------------------------------
 
   // Returns the native widget that contains the contents of the tab.
   virtual gfx::NativeView GetNativeView() = 0;
 
   // Returns the native widget with the main content of the tab (i.e. the main
@@ skipping 249 matching lines @@
 
  private:
   // This interface should only be implemented inside content.
   friend class WebContentsImpl;
   WebContents() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_