Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 16240016: gpu: Make pack/unpack alignment part of autogenerated state (Closed)

Created:
7 years, 6 months ago by Sami
Modified:
7 years, 6 months ago
Reviewers:
greggman
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

gpu: Make pack/unpack alignment part of autogenerated state This patch makes GL_PACK_ALIGNMENT and GL_UNPACK_ALIGNMENT part of the autogenerated GL state. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203990

Patch Set 1 #

Total comments: 1

Patch Set 2 : Sort states. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -200 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 chunks +20 lines, -4 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/context_state.h View 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/context_state.cc View 2 chunks +1 line, -6 lines 0 comments Download
M gpu/command_buffer/service/context_state_autogen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/context_state_impl_autogen.h View 1 12 chunks +200 lines, -172 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_0_autogen.h View 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Sami
7 years, 6 months ago (2013-05-31 18:04:33 UTC) #1
greggman
lgtm
7 years, 6 months ago (2013-05-31 19:46:56 UTC) #2
greggman
lgtm https://codereview.chromium.org/16240016/diff/1/gpu/command_buffer/build_gles2_cmd_buffer.py File gpu/command_buffer/build_gles2_cmd_buffer.py (right): https://codereview.chromium.org/16240016/diff/1/gpu/command_buffer/build_gles2_cmd_buffer.py#newcode7050 gpu/command_buffer/build_gles2_cmd_buffer.py:7050: for state_name in _STATES.keys(): can you change this ...
7 years, 6 months ago (2013-05-31 19:52:39 UTC) #3
Sami
On 2013/05/31 19:52:39, greggman wrote: > Then from this point on the diffs won't be ...
7 years, 6 months ago (2013-06-03 14:20:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/16240016/7001
7 years, 6 months ago (2013-06-03 14:20:25 UTC) #5
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
7 years, 6 months ago (2013-06-04 00:45:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/16240016/7001
7 years, 6 months ago (2013-06-04 09:44:41 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 17:12:06 UTC) #8
Message was sent while issue was closed.
Change committed as 203990

Powered by Google App Engine
This is Rietveld 408576698