Issue 16240003: Improve smi support in crankshaft

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16240003: Improve smi support in crankshaft (Closed)

Created:
7 years, 6 months ago by Toon Verwaest

Modified:
7 years, 6 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Improve smi support in crankshaft - Recover smi in phis if inputs are smi-typed - Don't record smi-typed values as pointers BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14926

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -105 lines)			Patch
M	src/hydrogen.cc	View	1	1 chunk	+0 lines, -17 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1	9 chunks	+27 lines, -32 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	1	3 chunks	+6 lines, -54 lines	0 comments	Download
M	src/lithium-allocator.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

https://chromiumcodereview.appspot.com/16240003/diff/2001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://chromiumcodereview.appspot.com/16240003/diff/2001/src/hydrogen-instructions.cc#newcode3568 src/hydrogen-instructions.cc:3568: bool tagged_smi_occurred = false; I don't think we should ...

7 years, 6 months ago (2013-05-31 16:39:40 UTC) #2

Toon Verwaest

7 years, 6 months ago (2013-06-03 16:57:43 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r14926 (presubmit successful).

Expand Messages | Collapse Messages