Issue 16236003: Add tracing to prefs for analyzing startup performance

Issue 16236003: Add tracing to prefs for analyzing startup performance (Closed)

Created:
7 years, 6 months ago by Andrew Hayden (chromium.org)

Modified:
7 years, 6 months ago

Reviewers:
battre

CC:
chromium-reviews, aberent, jeremy

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add tracing to prefs for analyzing startup performance BUG=222350 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203998

Patch Set 2 : Add semicolons per battre@ #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
M	chrome/browser/prefs/browser_prefs.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/prefs/chrome_pref_service_factory.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/prefs/pref_service_syncable_builder.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Andrew Hayden (chromium.org)

Minor change to add more startup tracing for issue 222350. Please take a look.

7 years, 6 months ago (2013-05-30 17:43:21 UTC) #1

battre

lgtm https://codereview.chromium.org/16236003/diff/1/chrome/browser/prefs/browser_prefs.cc File chrome/browser/prefs/browser_prefs.cc (right): https://codereview.chromium.org/16236003/diff/1/chrome/browser/prefs/browser_prefs.cc#newcode283 chrome/browser/prefs/browser_prefs.cc:283: TRACE_EVENT0("browser", "chrome::RegisterUserPrefs") nit: all TRACE_EVENT0 usage that I ...

7 years, 6 months ago (2013-06-03 20:24:21 UTC) #2

Andrew Hayden (chromium.org)

On 2013/06/03 20:24:21, battre wrote: > lgtm > > https://codereview.chromium.org/16236003/diff/1/chrome/browser/prefs/browser_prefs.cc > File chrome/browser/prefs/browser_prefs.cc (right): > ...

7 years, 6 months ago (2013-06-04 10:31:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/16236003/5001

7 years, 6 months ago (2013-06-04 10:31:29 UTC) #4

Message was sent while issue was closed.

Change committed as 203998

Expand Messages | Collapse Messages