Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16231013: device: Restructure the layout of gyp files. (Closed)

Created:
7 years, 6 months ago by tfarina
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Aaron Boodman, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

device: Restructure the layout of gyp files. This follow the same structure used by ui/keyboard/. Now the directory hierachy looks like this: device/bluetooth/bluetooth.gyp device/bluetooth/bluetooth_strings.gyp device/bluetooth/bluetooth_strings.grd device/bluetooth/strings device/usb/usb.gyp R=bryeung@chromium.org,miket@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203652

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : fix mac? #

Patch Set 4 : device_usb #

Patch Set 5 : doh forgot to rename the principal - the target #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -561 lines) Patch
M build/all.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_resources.gyp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/usb_device_permission.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/tools/build/repack_locales.py View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/tools/check_grd_for_unused_strings.py View 1 chunk +1 line, -1 line 0 comments Download
A device/bluetooth/bluetooth.gyp View 1 2 3 4 1 chunk +121 lines, -0 lines 0 comments Download
A + device/bluetooth/bluetooth_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
A + device/bluetooth/bluetooth_strings.gyp View 1 2 3 1 chunk +7 lines, -8 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_am.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_ar.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_bg.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_bn.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_ca.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_cs.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_da.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_de.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_el.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_en-GB.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_es.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_es-419.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_et.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_fa.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_fi.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_fil.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_fr.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_gu.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_hi.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_hr.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_hu.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_id.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_it.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_iw.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_ja.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_kn.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_ko.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_lt.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_lv.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_ml.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_mr.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_ms.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_nl.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_no.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_pl.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_pt-BR.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_pt-PT.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_ro.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_ru.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_sk.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_sl.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_sr.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_sv.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_sw.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_ta.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_te.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_th.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_tr.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_uk.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_vi.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_zh-CN.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + device/bluetooth/strings/device_bluetooth_strings_zh-TW.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
M device/device.gyp View 1 2 3 1 chunk +3 lines, -147 lines 0 comments Download
D device/device_bluetooth_strings.grd View 1 chunk +0 lines, -204 lines 0 comments Download
D device/device_bluetooth_strings.gyp View 1 chunk +0 lines, -31 lines 0 comments Download
D device/strings/device_bluetooth_strings_am.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_ar.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_bg.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_bn.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_ca.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_cs.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_da.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_de.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_el.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_en-GB.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_es.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_es-419.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_et.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_fa.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_fi.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_fil.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_fr.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_gu.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_hi.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_hr.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_hu.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_id.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_it.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_iw.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_ja.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_kn.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_ko.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_lt.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_lv.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_ml.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_mr.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_ms.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_nl.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_no.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_pl.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_pt-BR.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_pt-PT.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_ro.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_ru.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_sk.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_sl.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_sr.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_sv.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_sw.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_ta.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_te.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_th.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_tr.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_uk.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_vi.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_zh-CN.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
D device/strings/device_bluetooth_strings_zh-TW.xtb View 1 chunk +0 lines, -4 lines 0 comments Download
A device/usb/usb.gyp View 1 2 3 4 1 chunk +45 lines, -0 lines 0 comments Download
M device/usb/usb_ids.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
tfarina
Lei chrome/ Bryan + Miket device/ Thanks,
7 years, 6 months ago (2013-05-30 22:53:34 UTC) #1
Lei Zhang
chrome lgtm with a nit below. https://codereview.chromium.org/16231013/diff/2001/chrome/common/extensions/permissions/usb_device_permission.cc File chrome/common/extensions/permissions/usb_device_permission.cc (right): https://codereview.chromium.org/16231013/diff/2001/chrome/common/extensions/permissions/usb_device_permission.cc#newcode37 chrome/common/extensions/permissions/usb_device_permission.cc:37: // //device/usb/usb.gyp:usb is ...
7 years, 6 months ago (2013-05-30 22:55:27 UTC) #2
tfarina
https://codereview.chromium.org/16231013/diff/2001/chrome/common/extensions/permissions/usb_device_permission.cc File chrome/common/extensions/permissions/usb_device_permission.cc (right): https://codereview.chromium.org/16231013/diff/2001/chrome/common/extensions/permissions/usb_device_permission.cc#newcode37 chrome/common/extensions/permissions/usb_device_permission.cc:37: // //device/usb/usb.gyp:usb is not available when extensions are disabled. ...
7 years, 6 months ago (2013-05-31 01:14:58 UTC) #3
bryeung
lgtm
7 years, 6 months ago (2013-05-31 13:58:49 UTC) #4
miket_OOO
lgtm
7 years, 6 months ago (2013-05-31 15:54:03 UTC) #5
Lei Zhang
You may need to fix the mac build though.
7 years, 6 months ago (2013-05-31 17:53:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/16231013/14001
7 years, 6 months ago (2013-06-02 21:23:20 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-02 21:55:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/16231013/27001
7 years, 6 months ago (2013-06-02 22:01:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/16231013/17129
7 years, 6 months ago (2013-06-02 22:20:05 UTC) #10
commit-bot: I haz the power
7 years, 6 months ago (2013-06-03 00:22:31 UTC) #11
Message was sent while issue was closed. 
Change committed as 203652

Powered by Google App Engine
This is Rietveld 408576698