Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16224008: Update debugger for addition of Conic path verb (Closed)

Created:
7 years, 6 months ago by robertphillips
Modified:
7 years, 6 months ago
Reviewers:
djsollen, reed1
CC:
skia-review_googlegroups.com, umar.hansa
Visibility:
Public.

Description

Update debugger for addition of Conic path verb Committed: http://code.google.com/p/skia/source/detail?r=9438

Patch Set 1 #

Patch Set 2 : Addressed code review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M debugger/SkObjectParser.cpp View 1 2 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robertphillips
7 years, 6 months ago (2013-06-04 19:06:16 UTC) #1
robertphillips
7 years, 6 months ago (2013-06-04 19:14:55 UTC) #2
robertphillips
PTAL - it has been improved.
7 years, 6 months ago (2013-06-04 19:51:33 UTC) #3
reed1
lgtm
7 years, 6 months ago (2013-06-04 20:14:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/16224008/4001
7 years, 6 months ago (2013-06-04 21:18:05 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 21:51:26 UTC) #6
Message was sent while issue was closed. 
Change committed as 9438

Powered by Google App Engine
This is Rietveld 408576698