Open source WebCore.FeatureObserver histogram

Open source WebCore.FeatureObserver histogram

BUG=223859
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204407

[jar (doing other things), 2013-05-31 02:52:50]

Alexei: Please comment on histogtrams.xml.

[Alexei Svitkine (slow), 2013-05-31 13:57:38]

https://codereview.chromium.org/16223003/diff/2001/tools/metrics/histograms/h...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/16223003/diff/2001/tools/metrics/histograms/h...
tools/metrics/histograms/histograms.xml:9698:
http://src.chromium.org/viewvc/blink/trunk/Source/core/page/UseCounter.h for
Is it me, or is there no actual descriptions of the items in that file, just in
the names?

In that case, it's as good as the enum entry here already, so need to link to
it. (Or least, maybe not say "for descriptions").

https://codereview.chromium.org/16223003/diff/2001/tools/metrics/histograms/h...
tools/metrics/histograms/histograms.xml:11842: <enum name="FeatureObserver"
type="int">
Perhaps mention
http://src.chromium.org/viewvc/blink/trunk/Source/core/page/UseCounter.h here
instead with a comment?

[tyoshino (SeeGerritForStatus), 2013-06-03 05:01:55]

https://codereview.chromium.org/16223003/diff/2001/tools/metrics/histograms/h...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/16223003/diff/2001/tools/metrics/histograms/h...
tools/metrics/histograms/histograms.xml:9698:
http://src.chromium.org/viewvc/blink/trunk/Source/core/page/UseCounter.h for
On 2013/05/31 13:57:39, Alexei Svitkine wrote:
> Is it me, or is there no actual descriptions of the items in that file, just
in
> the names?
> 
> In that case, it's as good as the enum entry here already, so need to link to
> it. (Or least, maybe not say "for descriptions").

Removed.

https://codereview.chromium.org/16223003/diff/2001/tools/metrics/histograms/h...
tools/metrics/histograms/histograms.xml:11842: <enum name="FeatureObserver"
type="int">
On 2013/05/31 13:57:39, Alexei Svitkine wrote:
> Perhaps mention
> http://src.chromium.org/viewvc/blink/trunk/Source/core/page/UseCounter.h here
> instead with a comment?

Done.

[Alexei Svitkine (slow), 2013-06-05 11:56:55]

lgtm with a comment

https://codereview.chromium.org/16223003/diff/11001/tools/metrics/histograms/...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/16223003/diff/11001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:9946: Count of how many instances of
WebCore::Page use various features.
Please mention how this is sampled.

[tyoshino (SeeGerritForStatus), 2013-06-06 03:31:34]

https://codereview.chromium.org/16223003/diff/11001/tools/metrics/histograms/...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/16223003/diff/11001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:9946: Count of how many instances of
WebCore::Page use various features.
On 2013/06/05 11:56:56, Alexei Svitkine wrote:
> Please mention how this is sampled.

Done.

[commit-bot: I haz the power, 2013-06-06 03:34:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tyoshino@chromium.org/16223003/16001

[commit-bot: I haz the power, 2013-06-06 03:47:22]

Change committed as 204407