Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 16222002: Add Canadian Multilingual Keyboard as Caps rewrite exception. (Closed)

Created:
7 years, 6 months ago by Seigo Nonaka
Modified:
7 years, 6 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Add Canadian Multilingual Keyboard as Caps rewrite exception. To use ISO_Level5_Shift modifier, we have to do same things as German Neo Keyboard. BUG=240980 TEST=Manually checked on link Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203957

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/ui/ash/event_rewriter.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Seigo Nonaka
Hi Zach, Could you take a look? Thank you.
7 years, 6 months ago (2013-05-30 10:55:17 UTC) #1
Zachary Kuznia
lgtm
7 years, 6 months ago (2013-06-02 13:15:28 UTC) #2
Seigo Nonaka
Zach, thank you for your review! Adding sky@ as the owner of chrome/browser/ui/ash/ Hi Scott, ...
7 years, 6 months ago (2013-06-02 14:19:57 UTC) #3
sky
yusukes should review this. I'm rubber stamping but wait for him: LGTM
7 years, 6 months ago (2013-06-03 15:49:13 UTC) #4
Seigo Nonaka
Sure, Yusuke-san, could you review this CL? Thank you.
7 years, 6 months ago (2013-06-04 03:39:45 UTC) #5
Yusuke Sato
lgtm
7 years, 6 months ago (2013-06-04 05:47:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/16222002/1
7 years, 6 months ago (2013-06-04 05:49:14 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 13:50:45 UTC) #8
Message was sent while issue was closed.
Change committed as 203957

Powered by Google App Engine
This is Rietveld 408576698