Add telemetry to track the time an event spent waiting for the main thread.

content/browser/renderer_host/input/immediate_input_router_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

[nduca, 2013/08/15 01:41:04]

no unit test coverage for this new feature? how would we test the full stack?


[hint: do a patch that pulls the render_widget parts of the input receipt code
out, plus ideally the compositor side things,  and make it into a class. then
build a test that instantiates input router plus the child input handler classes
and then verifies that when you inject an input event, then do the right things
on the child input classes, you get the right calls back up on the client.]

Yes you're getting the bill for adding tests that should have been there for
ages. Sorry! Complain to your local TL for letting the stack get to the point
that there's so little test coverage in the first place. ^_^ This will be good
though! :)

Happy to talk to you offline if the concept here doesn't make sense. Think:
instead of testing this by instantiating real processes, instantitate the
classes that would be existing, mock out the IPC parts of things, and then poke
at the classes manually.

 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/browser/renderer_host/input/gesture_event_filter.h"
 #include "content/browser/renderer_host/input/immediate_input_router.h"
 #include "content/browser/renderer_host/input/input_router_client.h"
 #include "content/common/content_constants_internal.h"
 #include "content/common/edit_command.h"
 #include "content/common/input_messages.h"
@@ skipping 205 matching lines @@
     VLOG(1) << __FUNCTION__ << " called!";
     acked_wheel_event_ = event;
     RecordAckCalled(ack_result);
   }
   virtual void OnTouchEventAck(const TouchEventWithLatencyInfo& event,
                                InputEventAckState ack_result) OVERRIDE {
     VLOG(1) << __FUNCTION__ << " called!";
     acked_touch_event_ = event;
     RecordAckCalled(ack_result);
   }
-  virtual void OnGestureEventAck(const WebGestureEvent& event,
+  virtual void OnGestureEventAck(const GestureEventWithLatencyInfo& event,
                                  InputEventAckState ack_result) OVERRIDE {
     VLOG(1) << __FUNCTION__ << " called!";
     RecordAckCalled(ack_result);
   }
   virtual void OnUnexpectedEventAck(bool bad_message) OVERRIDE {
     VLOG(1) << __FUNCTION__ << " called!";
     unexpected_event_ack_called_ = true;
   }
 
   void ExpectSendCalled(bool called) {
@@ skipping 1919 matching lines @@
   EXPECT_EQ(1U, process_->sink().message_count());
   EXPECT_TRUE(process_->sink().GetUniqueMessageMatching(
                   InputMsg_HandleInputEvent::ID));
   process_->sink().ClearMessages();
 
   // Check that the correct unhandled wheel event was received.
   EXPECT_EQ(client_->acked_wheel_event().deltaY, -5);
 }
 
 }  // namespace content