Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1628)

Unified Diff: gpu/command_buffer/client/gles2_implementation_impl_autogen.h

Issue 162023002: Reduce internal Flush() in GL resource glGen/Delete APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Lock required in FreeContext(). Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/client/gles2_implementation_impl_autogen.h
diff --git a/gpu/command_buffer/client/gles2_implementation_impl_autogen.h b/gpu/command_buffer/client/gles2_implementation_impl_autogen.h
index 9dba99fc849569b990d26be73735cb23194f30f6..ec9ba97b48a3c147adf242a98f97f3087f6f403a 100644
--- a/gpu/command_buffer/client/gles2_implementation_impl_autogen.h
+++ b/gpu/command_buffer/client/gles2_implementation_impl_autogen.h
@@ -408,7 +408,8 @@ void GLES2Implementation::GenBuffers(GLsizei n, GLuint* buffers) {
MakeIds(this, 0, n, buffers);
GenBuffersHelper(n, buffers);
helper_->GenBuffersImmediate(n, buffers);
- helper_->CommandBufferHelper::Flush();
+ if (share_group_->bind_generates_resource())
+ helper_->CommandBufferHelper::Flush();
GPU_CLIENT_LOG_CODE_BLOCK({
for (GLsizei i = 0; i < n; ++i) {
GPU_CLIENT_LOG(" " << i << ": " << buffers[i]);
@@ -435,7 +436,8 @@ void GLES2Implementation::GenFramebuffers(GLsizei n, GLuint* framebuffers) {
MakeIds(this, 0, n, framebuffers);
GenFramebuffersHelper(n, framebuffers);
helper_->GenFramebuffersImmediate(n, framebuffers);
- helper_->CommandBufferHelper::Flush();
+ if (share_group_->bind_generates_resource())
+ helper_->CommandBufferHelper::Flush();
GPU_CLIENT_LOG_CODE_BLOCK({
for (GLsizei i = 0; i < n; ++i) {
GPU_CLIENT_LOG(" " << i << ": " << framebuffers[i]);
@@ -455,7 +457,8 @@ void GLES2Implementation::GenRenderbuffers(GLsizei n, GLuint* renderbuffers) {
MakeIds(this, 0, n, renderbuffers);
GenRenderbuffersHelper(n, renderbuffers);
helper_->GenRenderbuffersImmediate(n, renderbuffers);
- helper_->CommandBufferHelper::Flush();
+ if (share_group_->bind_generates_resource())
+ helper_->CommandBufferHelper::Flush();
GPU_CLIENT_LOG_CODE_BLOCK({
for (GLsizei i = 0; i < n; ++i) {
GPU_CLIENT_LOG(" " << i << ": " << renderbuffers[i]);
@@ -475,7 +478,8 @@ void GLES2Implementation::GenTextures(GLsizei n, GLuint* textures) {
MakeIds(this, 0, n, textures);
GenTexturesHelper(n, textures);
helper_->GenTexturesImmediate(n, textures);
- helper_->CommandBufferHelper::Flush();
+ if (share_group_->bind_generates_resource())
+ helper_->CommandBufferHelper::Flush();
GPU_CLIENT_LOG_CODE_BLOCK({
for (GLsizei i = 0; i < n; ++i) {
GPU_CLIENT_LOG(" " << i << ": " << textures[i]);
@@ -1517,7 +1521,8 @@ void GLES2Implementation::GenQueriesEXT(GLsizei n, GLuint* queries) {
MakeIds(this, 0, n, queries);
GenQueriesEXTHelper(n, queries);
helper_->GenQueriesEXTImmediate(n, queries);
- helper_->CommandBufferHelper::Flush();
+ if (share_group_->bind_generates_resource())
+ helper_->CommandBufferHelper::Flush();
GPU_CLIENT_LOG_CODE_BLOCK({
for (GLsizei i = 0; i < n; ++i) {
GPU_CLIENT_LOG(" " << i << ": " << queries[i]);
@@ -1558,7 +1563,8 @@ void GLES2Implementation::GenVertexArraysOES(GLsizei n, GLuint* arrays) {
MakeIds(this, 0, n, arrays);
GenVertexArraysOESHelper(n, arrays);
helper_->GenVertexArraysOESImmediate(n, arrays);
- helper_->CommandBufferHelper::Flush();
+ if (share_group_->bind_generates_resource())
+ helper_->CommandBufferHelper::Flush();
GPU_CLIENT_LOG_CODE_BLOCK({
for (GLsizei i = 0; i < n; ++i) {
GPU_CLIENT_LOG(" " << i << ": " << arrays[i]);

Powered by Google App Engine
This is Rietveld 408576698