Issue 16196006: Move common default expectations for network library to CrosMock

Issue 16196006: Move common default expectations for network library to CrosMock (Closed)

Created:
7 years, 6 months ago by gauravsh

Modified:
7 years, 6 months ago

Reviewers:
stevenjb, Nikita (slow), nkostylev (pls use chromium), ygorshenin1

CC:
chromium-reviews, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move common default expectations for network library to CrosMock Removes mock expectations that are no longer needed. This also results in removal of all direct {Mock}NetworkLibrary dependencies in chromeos/login/*. BUG=189035 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203979

Patch Set 1 #

Patch Set 2 : cleanup #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -63 lines)			Patch
M	chrome/browser/chromeos/cros/cros_mock.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/existing_user_controller_browsertest.cc	View		4 chunks	+1 line, -12 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_browsertest.cc	View		3 chunks	+1 line, -9 lines	0 comments	Download
M	chrome/browser/chromeos/login/screen_locker_browsertest.cc	View		2 chunks	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/login/screens/network_screen_browsertest.cc	View	1	7 chunks	+0 lines, -28 lines	0 comments	Download
M	chrome/browser/chromeos/login/screens/update_screen_browsertest.cc	View		4 chunks	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

gauravsh

stevenjb: CrosMock changes nkostylev: for browser test change under chromeos/login/*

7 years, 6 months ago (2013-05-31 20:08:02 UTC) #1

gauravsh

ygorshenin: Could you help review the changes under login/?

7 years, 6 months ago (2013-06-03 16:31:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gauravsh@chromium.org/16196006/2001

7 years, 6 months ago (2013-06-03 16:44:45 UTC) #5

commit-bot: I haz the power

The commit queue went berserk retrying too often for a seemingly flaky test on builder ...

7 years, 6 months ago (2013-06-04 07:08:49 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gauravsh@chromium.org/16196006/2001

7 years, 6 months ago (2013-06-04 15:26:36 UTC) #8

Message was sent while issue was closed.

Change committed as 203979

Expand Messages | Collapse Messages