Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 16196004: Do not alert if devices with user/eng Android builds are not provisioned (Closed)

Created:
7 years, 6 months ago by Siva Chandra
Modified:
7 years, 6 months ago
Reviewers:
Isaac (away)
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, cmp
Visibility:
Public.

Description

Do not alert if devices with user/eng Android builds are not provisioned. BUG=245058 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205021

Patch Set 1 #

Patch Set 2 : Alert for userdebug and eng builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/android/device_status_check.py View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Siva Chandra
Tested locally.
7 years, 6 months ago (2013-05-29 22:08:31 UTC) #1
Isaac (away)
why can't eng builds be provisioned?
7 years, 6 months ago (2013-06-03 07:36:52 UTC) #2
Siva Chandra
On 2013/06/03 07:36:52, Isaac wrote: > why can't eng builds be provisioned? AFAIK, only the ...
7 years, 6 months ago (2013-06-03 08:36:20 UTC) #3
Isaac (away)
I'm not following; however I don't think we should filter eng builds from provision alerts.
7 years, 6 months ago (2013-06-03 08:50:54 UTC) #4
cmp_google
On 2013/06/03 08:50:54, Isaac wrote: > I'm not following; however I don't think we should ...
7 years, 6 months ago (2013-06-03 15:40:26 UTC) #5
Isaac (away)
That's fine, but we should only distinguish behavior on eng vs userdebug android builds as ...
7 years, 6 months ago (2013-06-05 04:36:19 UTC) #6
Siva Chandra
On 2013/06/05 04:36:19, Isaac wrote: > That's fine, but we should only distinguish behavior on ...
7 years, 6 months ago (2013-06-07 23:03:06 UTC) #7
Isaac (away)
lgtm
7 years, 6 months ago (2013-06-07 23:08:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/16196004/6001
7 years, 6 months ago (2013-06-07 23:20:43 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-06-08 05:02:49 UTC) #10
Message was sent while issue was closed.
Change committed as 205021

Powered by Google App Engine
This is Rietveld 408576698