Source/core/html/InputType.cpp - Issue 16194013: Mouse press should focus on any types of form controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/InputType.cpp

Issue 16194013: Mouse press should focus on any types of form controls. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase, common->default, etc. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/InputType.cpp

diff --git a/Source/core/html/InputType.cpp b/Source/core/html/InputType.cpp

index 18bead56a6fcf5926480560f1ef299d12bfdb957..8aa8534e3bd09efce04e05adb5fb28f03e89800d 100644

--- a/Source/core/html/InputType.cpp

+++ b/Source/core/html/InputType.cpp

@@ -531,9 +531,9 @@ bool InputType::isKeyboardFocusable(KeyboardEvent* event) const

return element()->isTextFormControlKeyboardFocusable(event);

}

-bool InputType::isMouseFocusable() const

+bool InputType::shouldShowFocusRingOnMouseFocus() const

{

- return element()->isTextFormControlMouseFocusable();

+ return false;

}

bool InputType::shouldUseInputMethod() const