Source/core/html/HTMLTextAreaElement.cpp - Issue 16194013: Mouse press should focus on any types of form controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTextAreaElement.cpp

Issue 16194013: Mouse press should focus on any types of form controls. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase, common->default, etc. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLTextAreaElement.cpp

diff --git a/Source/core/html/HTMLTextAreaElement.cpp b/Source/core/html/HTMLTextAreaElement.cpp

index 62c6eca8f87f569b8a334293b4a7f8b4021bae11..c8e980bacb3f074bfcece9ed922302b50d69cdb5 100644

--- a/Source/core/html/HTMLTextAreaElement.cpp

+++ b/Source/core/html/HTMLTextAreaElement.cpp

@@ -241,9 +241,9 @@ bool HTMLTextAreaElement::isKeyboardFocusable(KeyboardEvent*) const

return isFocusable();

}

-bool HTMLTextAreaElement::isMouseFocusable() const

+bool HTMLTextAreaElement::shouldShowFocusRingOnMouseFocus() const

{

- return isFocusable();

+ return true;

}

void HTMLTextAreaElement::updateFocusAppearance(bool restorePreviousSelection)