Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 16194013: Mouse press should focus on any types of form controls. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase, common->default, etc. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 350 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 bool HTMLInputElement::hasCustomFocusLogic() const 361 bool HTMLInputElement::hasCustomFocusLogic() const
362 { 362 {
363 return m_inputType->hasCustomFocusLogic(); 363 return m_inputType->hasCustomFocusLogic();
364 } 364 }
365 365
366 bool HTMLInputElement::isKeyboardFocusable(KeyboardEvent* event) const 366 bool HTMLInputElement::isKeyboardFocusable(KeyboardEvent* event) const
367 { 367 {
368 return m_inputType->isKeyboardFocusable(event); 368 return m_inputType->isKeyboardFocusable(event);
369 } 369 }
370 370
371 bool HTMLInputElement::isMouseFocusable() const 371 bool HTMLInputElement::shouldShowFocusRingOnMouseFocus() const
372 { 372 {
373 return m_inputType->isMouseFocusable(); 373 return m_inputType->shouldShowFocusRingOnMouseFocus();
374 } 374 }
375 375
376 bool HTMLInputElement::isTextFormControlKeyboardFocusable(KeyboardEvent* event) const 376 bool HTMLInputElement::isTextFormControlKeyboardFocusable(KeyboardEvent* event) const
377 { 377 {
378 return HTMLTextFormControlElement::isKeyboardFocusable(event); 378 return HTMLTextFormControlElement::isKeyboardFocusable(event);
379 } 379 }
380 380
381 bool HTMLInputElement::isTextFormControlMouseFocusable() const
382 {
383 return HTMLTextFormControlElement::isMouseFocusable();
384 }
385
386 void HTMLInputElement::updateFocusAppearance(bool restorePreviousSelection) 381 void HTMLInputElement::updateFocusAppearance(bool restorePreviousSelection)
387 { 382 {
388 if (isTextField()) { 383 if (isTextField()) {
389 if (!restorePreviousSelection || !hasCachedSelection()) 384 if (!restorePreviousSelection || !hasCachedSelection())
390 select(); 385 select();
391 else 386 else
392 restoreCachedSelection(); 387 restoreCachedSelection();
393 if (document()->frame()) 388 if (document()->frame())
394 document()->frame()->selection()->revealSelection(); 389 document()->frame()->selection()->revealSelection();
395 } else 390 } else
(...skipping 1527 matching lines...) Expand 10 before | Expand all | Expand 10 after
1923 } 1918 }
1924 1919
1925 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI) 1920 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
1926 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer() 1921 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer()
1927 { 1922 {
1928 return m_inputType->customStyleForRenderer(originalStyleForRenderer()); 1923 return m_inputType->customStyleForRenderer(originalStyleForRenderer());
1929 } 1924 }
1930 #endif 1925 #endif
1931 1926
1932 } // namespace 1927 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698