about:net-internals#prerender: Add information about load state of prerender

about:net-internals#prerender:  Add information
about whether a prerender has finished loading or not.

Also wait until a prerender has finished loading in the
browser test before swapping in the prerender.  This is
needed before https://codereview.chromium.org/15041004/
can be landed (Which prevents a prerender from being
swapped in before commit, to fix a bug).

BUG=234809
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203420

[mmenke, 2013-05-29 15:30:01]

eroman:  Please review the HTML and JS files.

gavin:  Please review the prerender_contents change.

creis:  FYI.

[eroman, 2013-05-29 16:45:37]

lgtm

https://codereview.chromium.org/16194008/diff/3001/chrome/browser/resources/n...
File chrome/browser/resources/net_internals/prerender_view.html (right):

https://codereview.chromium.org/16194008/diff/3001/chrome/browser/resources/n...
chrome/browser/resources/net_internals/prerender_view.html:34: <td
jscontent="is_loaded"></td>
I keep forgetting, but what happens if this isn't defined? i.e. loading an old
log.

https://codereview.chromium.org/16194008/diff/3001/chrome/test/data/webui/net...
File chrome/test/data/webui/net_internals/prerender_view.js (right):

https://codereview.chromium.org/16194008/diff/3001/chrome/test/data/webui/net...
chrome/test/data/webui/net_internals/prerender_view.js:103: if
(!prerenderInfo.active[0].is_loaded)
is it a given that active[0] exists?

[mmenke, 2013-05-29 17:11:28]

Thanks for the feedback.

https://codereview.chromium.org/16194008/diff/3001/chrome/browser/resources/n...
File chrome/browser/resources/net_internals/prerender_view.html (right):

https://codereview.chromium.org/16194008/diff/3001/chrome/browser/resources/n...
chrome/browser/resources/net_internals/prerender_view.html:34: <td
jscontent="is_loaded"></td>
On 2013/05/29 16:45:38, eroman wrote:
> I keep forgetting, but what happens if this isn't defined? i.e. loading an old
> log.

"null" is displayed.  I don't think it's worth the effort to do better.

https://codereview.chromium.org/16194008/diff/3001/chrome/test/data/webui/net...
File chrome/test/data/webui/net_internals/prerender_view.js (right):

https://codereview.chromium.org/16194008/diff/3001/chrome/test/data/webui/net...
chrome/test/data/webui/net_internals/prerender_view.js:103: if
(!prerenderInfo.active[0].is_loaded)
On 2013/05/29 16:45:38, eroman wrote:
> is it a given that active[0] exists?

Yes.

The first call to this function is when there are no prerender at all.  At this
point we're at the STATE.START_PRERENDERING state.

Then we're only called on update.  The only way we could be updated is if an
entry is added to active, added to history, or moves from active to history. 
There's only one prerender request in all these tests.  If we expect it to fail
(And thus go to history), we skip this state.

So we expect the prerender to succeed, so we'll have to see it as active (Since
we haven't visited it yet, it shouldn't be added to the history - if it is, the
test will fail at another step, anyways).

[Charlie Reis, 2013-05-30 16:04:52]

Thanks for putting this together, Matt!  LGTM for fixing my other CL.

Gavin, do you have a moment to review?

[gavinp, 2013-05-31 14:22:07]

lgtm

[mmenke, 2013-05-31 14:24:36]

On 2013/05/31 14:22:07, gavinp wrote:
> lgtm

Thanks!

[commit-bot: I haz the power, 2013-05-31 14:24:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/16194008/3001

[commit-bot: I haz the power, 2013-05-31 16:45:08]

Change committed as 203420