Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Issue 16194002: Make ScopedStyleResolver use apply-author-styles of a given element's treescope. (Closed)

Created:
7 years, 6 months ago by tasak
Modified:
7 years, 6 months ago
CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, darktears
Visibility:
Public.

Description

Make ScopedStyleResolver use apply-author-styles of a given element's treescope. Suppose that a given shadow tree's apply-author-styles is true. Currently rules only in the nesting tree are applicable to elements in the shadow tree. However, rules in all enclosing trees should be applicable. TEST=No new tests. Rebased the existing one. BUG=244779 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151709

Patch Set 1 #

Total comments: 10

Patch Set 2 : Rewrite layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -213 lines) Patch
M LayoutTests/fast/css/style-scoped/style-scoped-apply-author-styles.html View 1 3 chunks +152 lines, -130 lines 0 comments Download
M LayoutTests/fast/css/style-scoped/style-scoped-apply-author-styles-expected.txt View 1 1 chunk +26 lines, -26 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.h View 1 3 chunks +2 lines, -6 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.cpp View 1 3 chunks +13 lines, -44 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
tasak
7 years, 6 months ago (2013-05-29 10:18:49 UTC) #1
hayato
On 2013/05/29 10:18:49, tasak wrote: I know the background of this change, but could you ...
7 years, 6 months ago (2013-05-29 10:21:54 UTC) #2
tasak
On 2013/05/29 10:21:54, hayato wrote: > On 2013/05/29 10:18:49, tasak wrote: > > I know ...
7 years, 6 months ago (2013-05-29 10:26:22 UTC) #3
hayato
Just a quick review. I'll take another look tomorrow. https://codereview.chromium.org/16194002/diff/1/LayoutTests/fast/css/style-scoped/style-scoped-apply-author-styles.html File LayoutTests/fast/css/style-scoped/style-scoped-apply-author-styles.html (right): https://codereview.chromium.org/16194002/diff/1/LayoutTests/fast/css/style-scoped/style-scoped-apply-author-styles.html#newcode93 LayoutTests/fast/css/style-scoped/style-scoped-apply-author-styles.html:93: ...
7 years, 6 months ago (2013-05-29 11:16:26 UTC) #4
hayato
It's optional and can be done as another patch, but I am feeling that we ...
7 years, 6 months ago (2013-05-30 08:16:30 UTC) #5
dglazkov
I defer review to hayato.
7 years, 6 months ago (2013-05-30 16:51:59 UTC) #6
tasak
Thank you for reviewing. https://codereview.chromium.org/16194002/diff/1/LayoutTests/fast/css/style-scoped/style-scoped-apply-author-styles.html File LayoutTests/fast/css/style-scoped/style-scoped-apply-author-styles.html (right): https://codereview.chromium.org/16194002/diff/1/LayoutTests/fast/css/style-scoped/style-scoped-apply-author-styles.html#newcode5 LayoutTests/fast/css/style-scoped/style-scoped-apply-author-styles.html:5: <script src="../../dom/shadow/resources/polyfill.js"></script> On 2013/05/30 08:16:30, ...
7 years, 6 months ago (2013-05-31 10:06:58 UTC) #7
hayato
lgtm. On 2013/05/31 10:06:58, tasak wrote: > Thank you for reviewing. > > https://codereview.chromium.org/16194002/diff/1/LayoutTests/fast/css/style-scoped/style-scoped-apply-author-styles.html > ...
7 years, 6 months ago (2013-06-03 01:02:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/16194002/10001
7 years, 6 months ago (2013-06-03 04:23:39 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=8328
7 years, 6 months ago (2013-06-03 05:47:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/16194002/10001
7 years, 6 months ago (2013-06-04 00:29:31 UTC) #11
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 00:29:51 UTC) #12
Message was sent while issue was closed.
Change committed as 151709

Powered by Google App Engine
This is Rietveld 408576698