Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 16190007: Avoid underlining misspellings when typing inside a word (Closed)

Created:
7 years, 6 months ago by please use gerrit instead
Modified:
7 years, 6 months ago
CC:
blink-reviews, eae+blinkwatch, groby-ooo-7-16, rpetterson, tony
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Avoid underlining misspellings when typing inside a word This CL changes TypingCommand to cancel ongoing spellcheck requests when user types a new character. If spellcheck is slow enough to not return after every character that user types, then spellcheck results can arrive after a user has typed several characters since spellcheck request. This can happen, for example, if spellcheck service is accessed over network. If the user is typing in the middle of a word, then the stale spellcheck result will appear to underline only a part of the word or include additional space around the word. TEST=WebFrameTest.SlowSpellcheckMarkerPosition BUG=179639 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151707

Patch Set 1 #

Patch Set 2 : Fix crash in layout test #

Patch Set 3 : Clear the queue, too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -0 lines) Patch
M Source/WebKit/chromium/tests/WebFrameTest.cpp View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M Source/core/editing/SpellChecker.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/SpellChecker.cpp View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/editing/TypingCommand.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
please use gerrit instead
Adam: PTAL.
7 years, 6 months ago (2013-05-31 15:32:28 UTC) #1
abarth-chromium
This CL looks reasonable to me, but I'm not sure I'm the right person to ...
7 years, 6 months ago (2013-05-31 17:32:05 UTC) #2
please use gerrit instead
Tony: Do you think you'd be a good reviewer for this CL?
7 years, 6 months ago (2013-05-31 17:35:40 UTC) #3
abarth-chromium
I think Tony is on leave at the moment...
7 years, 6 months ago (2013-05-31 17:41:45 UTC) #4
please use gerrit instead
Hajime: Do you think that you would be a good reviewer for this CL?
7 years, 6 months ago (2013-05-31 18:07:43 UTC) #5
Hajime Morrita
lgtm considering that this fixes a crash. SpellChecker has a list of pending spellcheck requests. ...
7 years, 6 months ago (2013-06-03 00:23:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/16190007/5001
7 years, 6 months ago (2013-06-03 17:13:44 UTC) #7
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=992
7 years, 6 months ago (2013-06-03 17:24:09 UTC) #8
please use gerrit instead
Adam: Need an OWNERS l-g.
7 years, 6 months ago (2013-06-03 17:30:42 UTC) #9
abarth-chromium
test LGTM
7 years, 6 months ago (2013-06-03 18:51:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/16190007/19001
7 years, 6 months ago (2013-06-03 18:53:27 UTC) #11
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 00:03:53 UTC) #12
Message was sent while issue was closed.
Change committed as 151707

Powered by Google App Engine
This is Rietveld 408576698