Issue 16189010: drive: Add DownloadOperationTest

Issue 16189010: drive: Add DownloadOperationTest (Closed)

Created:
7 years, 6 months ago by hashimoto

Modified:
7 years, 6 months ago

Reviewers:
kinaba

CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik+watch_chromium.org, oshima+watch_chromium.org, tfarina, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Add DownloadOperationTest Move DownloadOperation related tests from FileSystemTest to newly added DownloadedOperationTest. Add a new method FakeFreeDiskSpaceGetter::Reset(). BUG=244344 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203134

Patch Set 1 : mv file_system_unittest.cc file_system/download_operation_unittest.cc #

Patch Set 2 : Remove uninterested tests #

Patch Set 3 : codereview #

Total comments: 2

Patch Set 4 : rebase & fix a nit #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+408 lines, -367 lines)			Patch
M	chrome/browser/chromeos/drive/fake_free_disk_space_getter.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/fake_free_disk_space_getter.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/drive/file_system/download_operation_unittest.cc	View	1 2	1 chunk	+393 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/operation_test_base.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_unittest.cc	View	1 2 3	5 chunks	+4 lines, -367 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hashimoto

Please review Patch Set 3. Looking at diff against Patch Set 2 might make reviewing ...

7 years, 6 months ago (2013-05-30 06:31:45 UTC) #1

kinaba

lgtm! https://codereview.chromium.org/16189010/diff/21002/chrome/browser/chromeos/drive/file_system_unittest.cc File chrome/browser/chromeos/drive/file_system_unittest.cc (right): https://codereview.chromium.org/16189010/diff/21002/chrome/browser/chromeos/drive/file_system_unittest.cc#newcode14 chrome/browser/chromeos/drive/file_system_unittest.cc:14: #include "base/json/json_file_value_serializer.h" not used anymore.

7 years, 6 months ago (2013-05-30 07:23:07 UTC) #2

hashimoto

https://codereview.chromium.org/16189010/diff/21002/chrome/browser/chromeos/drive/file_system_unittest.cc File chrome/browser/chromeos/drive/file_system_unittest.cc (right): https://codereview.chromium.org/16189010/diff/21002/chrome/browser/chromeos/drive/file_system_unittest.cc#newcode14 chrome/browser/chromeos/drive/file_system_unittest.cc:14: #include "base/json/json_file_value_serializer.h" On 2013/05/30 07:23:07, kinaba wrote: > not ...

7 years, 6 months ago (2013-05-30 07:48:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/16189010/25001

7 years, 6 months ago (2013-05-30 07:48:54 UTC) #4

Message was sent while issue was closed.

Change committed as 203134

Expand Messages | Collapse Messages