Reduce wait time for Windows in AudioOutputController:WaitTillDataReady()

Reduce wait time for Windows in AudioOutputController:WaitTillDataReady()

This timeout was long to work around a problem that has been resolved
elsewhere.
I'm also changing the histogram name to match the condensed format
that is now preferred. In addition I've added a new boolean histogram
to indicate if the data was ready or not.

BUG=244939
BUG=242726
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203065

[DaveMoore, 2013-05-29 18:05:19]

Make sure histogram names match

[DaveMoore, 2013-05-29 18:06:56]

dalecurtis: audio changes
jar: histogram changes

[DaleCurtis, 2013-05-29 18:27:45]

https://codereview.chromium.org/16189009/diff/2001/media/audio/audio_output_c...
File media/audio/audio_output_controller.cc (right):

https://codereview.chromium.org/16189009/diff/2001/media/audio/audio_output_c...
media/audio/audio_output_controller.cc:313:
UMA_HISTOGRAM_BOOLEAN("Media.AudioOutputController.DataReady", ready);
Instead of adding this new statistic we should fix the stat that's already
recorded in AudioSyncReader since it records the same thing. It's off currently
since we always call WaitTillDataReady() here which AudioSyncReader doesn't know
about.

Ideally I'd like to see all of this waiting code moved into AudioSyncReader and
the WaitTillDataReady() interface method removed. There's one use case which
makes this tricky though: Virtual streams.

You don't have to do this in this CL, but I'd rather not add this new stat in
favor of fixing the old one. I'll take some time to fix that up this week.

[DaveMoore, 2013-05-29 18:32:23]

Remove new histogram as asked

[DaveMoore, 2013-05-29 18:33:03]

https://codereview.chromium.org/16189009/diff/2001/media/audio/audio_output_c...
File media/audio/audio_output_controller.cc (right):

https://codereview.chromium.org/16189009/diff/2001/media/audio/audio_output_c...
media/audio/audio_output_controller.cc:313:
UMA_HISTOGRAM_BOOLEAN("Media.AudioOutputController.DataReady", ready);
On 2013/05/29 18:27:46, DaleCurtis wrote:
> Instead of adding this new statistic we should fix the stat that's already
> recorded in AudioSyncReader since it records the same thing. It's off
currently
> since we always call WaitTillDataReady() here which AudioSyncReader doesn't
know
> about.
> 
> Ideally I'd like to see all of this waiting code moved into AudioSyncReader
and
> the WaitTillDataReady() interface method removed. There's one use case which
> makes this tricky though: Virtual streams.
> 
> You don't have to do this in this CL, but I'd rather not add this new stat in
> favor of fixing the old one. I'll take some time to fix that up this week.

Done.

[DaleCurtis, 2013-05-29 18:48:06]

lgtm

[jar (doing other things), 2013-05-29 19:53:52]

Alexei: Can you comment on the hisotgrams?

[Alexei Svitkine (slow), 2013-05-29 21:25:07]

https://codereview.chromium.org/16189009/diff/17001/tools/metrics/histograms/...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/16189009/diff/17001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:2189: <histogram
name="Media.AudioOutputControllerDataNotReady" units="ms">
We don't usually remove histograms from this file, just mark them as obsolete
using a tag. (Since their names are used for hashing by the dashboard, to map
hashes to the correct histogram names.)

https://codereview.chromium.org/16189009/diff/17001/tools/metrics/histograms/...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/16189009/diff/17001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:14749: <fieldtrial
name="MediaAudioOutputControllerTime" separator=".">
Hmm, I don't quite understand how this is supposed to match the histogram name
you're using in the code:

Media.AudioOutputController.WaitForDataTime

Note the extra dot.

Jim, perhaps you could review this part, I'm not very familiar with this use of
the fieldtrial entry in histograms.xml.

[DaleCurtis, 2013-05-29 21:39:06]

https://codereview.chromium.org/16189009/diff/17001/media/audio/audio_output_...
File media/audio/audio_output_controller.cc (left):

https://codereview.chromium.org/16189009/diff/17001/media/audio/audio_output_...
media/audio/audio_output_controller.cc:336:
UMA_HISTOGRAM_CUSTOM_TIMES("Media.AudioOutputControllerDataNotReady",
Actually, you can revert the histogram change too. I've got a CL close to finish
which moves this statistic into AudioSyncReader, so it won't be able to use the
AudioOutputController group.  Here's my WIP CL which merges this one in for now.

[DaleCurtis, 2013-05-29 21:39:32]

Whoops, forgot the link: https://codereview.chromium.org/16103007/

[DaveMoore, 2013-05-29 22:11:06]

Remove histogram change as asked

[DaleCurtis, 2013-05-29 22:38:30]

lgtm

[commit-bot: I haz the power, 2013-05-29 22:44:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davemoore@chromium.org/16189009/27001

[commit-bot: I haz the power, 2013-05-30 04:40:44]

Change committed as 203065