Issue 16176004: Add the number of alloc and free in the dmprof expand command.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16176004: Add the number of alloc and free in the dmprof expand command. (Closed)

Created:
7 years, 6 months ago by Dai Mikurube (NOT FULLTIME)

Modified:
7 years, 6 months ago

Reviewers:
peria

CC:
chromium-reviews, dmikurube+memory_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add the number of alloc and free in the dmprof expand command. BUG=123750 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205498

Patch Set 3 : rebased and fixed #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	tools/deep_memory_profiler/dmprof.py	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Dai Mikurube (NOT FULLTIME)

Peria-san, Could you take a look at this small change when you have time?

7 years, 6 months ago (2013-06-11 08:31:43 UTC) #1

peria

LGTM with a nit. https://codereview.chromium.org/16176004/diff/2001/tools/deep_memory_profiler/dmprof.py File tools/deep_memory_profiler/dmprof.py (right): https://codereview.chromium.org/16176004/diff/2001/tools/deep_memory_profiler/dmprof.py#newcode1668 tools/deep_memory_profiler/dmprof.py:1668: stacktrace_sequence += '(type=%s)' % bucket.symbolized_typeinfo ...

7 years, 6 months ago (2013-06-11 08:36:36 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/16176004/7001

7 years, 6 months ago (2013-06-11 08:54:28 UTC) #4

Message was sent while issue was closed.

Change committed as 205498

Expand Messages | Collapse Messages

Issue 16176004: Add the number of alloc and free in the dmprof expand command. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebased and fixed #

Messages