Large Cursor: Add the toggle menuitem to a11y menu in uber tray

Large Cursor: Add the toggle menuitem to a11y menu in uber tray.

This patch adds the menuitem to toggle Large cursor feature. It is available only on Login Screen.

BUG=247255
TEST=manual and browser_test passes.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204798

[yoshiki, 2013-06-06 16:18:49]

@derat, @stevenjb: Could you take a look at following files? Thanks.

@derat:
- ash/*
- chrome/browser/ui/ash/*

@stevenjb:
- ash/system/*
- chrome/browser/chromeos/system/*

[Daniel Erat, 2013-06-06 16:22:35]

lgtm

https://codereview.chromium.org/16175004/diff/3001/ash/shell_delegate.h
File ash/shell_delegate.h (right):

https://codereview.chromium.org/16175004/diff/3001/ash/shell_delegate.h#newco...
ash/shell_delegate.h:185: // Invoked to enable the large cursor.
nit: s/the large cursor/large cursors/

(this is just a suggestion for these comments -- i think it's fine to leave the
rest of the code referring to "large cursor" rather than e.g. "large cursors")

https://codereview.chromium.org/16175004/diff/3001/ash/shell_delegate.h#newco...
ash/shell_delegate.h:188: // Returns if the large cursor is enabled or not.
nit: s/the large cursor is/large cursors are/

[stevenjb, 2013-06-06 17:01:56]

lgtm

[yoshiki, 2013-06-07 03:54:10]

Thanks. Going to commit.

https://codereview.chromium.org/16175004/diff/3001/ash/shell_delegate.h
File ash/shell_delegate.h (right):

https://codereview.chromium.org/16175004/diff/3001/ash/shell_delegate.h#newco...
ash/shell_delegate.h:185: // Invoked to enable the large cursor.
On 2013/06/06 16:22:35, Daniel Erat wrote:
> nit: s/the large cursor/large cursors/
> 
> (this is just a suggestion for these comments -- i think it's fine to leave
the
> rest of the code referring to "large cursor" rather than e.g. "large cursors")

Thanks for suggestion. "Large cursor" is the name of the feature and plural is
not good. I changed "large cursor" into "Large Cursor" to indicate it is a
feature name.

https://codereview.chromium.org/16175004/diff/3001/ash/shell_delegate.h#newco...
ash/shell_delegate.h:188: // Returns if the large cursor is enabled or not.
On 2013/06/06 16:22:35, Daniel Erat wrote:
> nit: s/the large cursor is/large cursors are/

Ditto.

[commit-bot: I haz the power, 2013-06-07 03:54:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/16175004/20001

[commit-bot: I haz the power, 2013-06-07 05:46:14]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win7_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-06-07 07:17:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/16175004/32001

[commit-bot: I haz the power, 2013-06-07 12:52:04]

Change committed as 204798